-
Notifications
You must be signed in to change notification settings - Fork 2
scrub MNE name/logo/etc #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! I'm the It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃 |
|
macOS install failures: |
| logger -p 'install.info' "ℹ️ Setting custom folder icon for $MNE_APP_DIR and $MNE_APP_DIR_ROOT to $MNE_ICON_PATH." | ||
| for destPath in "$MNE_APP_DIR" "$MNE_APP_DIR_ROOT"; do | ||
| logger -p 'install.info' "ℹ️ Setting custom folder icon for $destPath to $MNE_ICON_PATH." | ||
| SPI_ICON_PATH="$PREFIX/Menu/mne.png" # TODO FIXME where is this image coming from / what would be the equivalent for Scientific Python? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be this:
https://github.com/conda-forge/mne-feedstock/blob/main/recipe/menu/mne.png
That's an asset that's part of the mne-installer-menus feedstock:
So this post-install script knows that the mne-installer-menus will be installed, and that its mne.png will land in Menu/mne.png. So we'll need to see if there is some place we can get a scientific Python PNG... if not, then we could create a conda-forge feedstock for it. Not sure what conda-forge project / recipe we would want to create for it...
|
commits here have been cherry-pick incorporated into #3 |
this scrubs MNE from the
assets/folder and the README. There are a couple of TODOs: