Skip to content

Conversation

@drammock
Copy link
Member

@drammock drammock commented May 12, 2025

this scrubs MNE from the assets/ folder and the README. There are a couple of TODOs:

  • the README has a TBD link to a tutorial explaining how to use the installers. Maybe we should just comment that out for now?
  • one of the post-install scripts links to an image "mne.png" which I'm not sure where it's coming from, so I'm not sure if just changing it to "scientific-python.png" is going to work. Maybe @larsoner can just pop in here and tell us?

@autofix-troubleshooter
Copy link

Hi! I'm the autofix logoautofix.ci troubleshooter bot.

It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃

@drammock drammock marked this pull request as ready for review May 12, 2025 21:17
@drammock
Copy link
Member Author

macOS install failures:

2025-05-12 21:26:32+00 Mac-1747083657516 package_script_service[5210]: ./postinstall: mv: rename /Applications/*(ScientificPython).app to /Applications/Scientific-Python/1.9.0_0/: No such file or directory
2025-05-12 21:26:32+00 Mac-1747083657516 package_script_service[5210]: ./postinstall: ERROR: could not run user-provided post_install script!

logger -p 'install.info' "ℹ️ Setting custom folder icon for $MNE_APP_DIR and $MNE_APP_DIR_ROOT to $MNE_ICON_PATH."
for destPath in "$MNE_APP_DIR" "$MNE_APP_DIR_ROOT"; do
logger -p 'install.info' "ℹ️ Setting custom folder icon for $destPath to $MNE_ICON_PATH."
SPI_ICON_PATH="$PREFIX/Menu/mne.png" # TODO FIXME where is this image coming from / what would be the equivalent for Scientific Python?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be this:

https://github.com/conda-forge/mne-feedstock/blob/main/recipe/menu/mne.png

That's an asset that's part of the mne-installer-menus feedstock:

https://github.com/conda-forge/mne-feedstock/blob/08355b8a5cd76fec2ae7d4e3d16245fdc754da5a/recipe/meta.yaml#L122

So this post-install script knows that the mne-installer-menus will be installed, and that its mne.png will land in Menu/mne.png. So we'll need to see if there is some place we can get a scientific Python PNG... if not, then we could create a conda-forge feedstock for it. Not sure what conda-forge project / recipe we would want to create for it...

@drammock
Copy link
Member Author

commits here have been cherry-pick incorporated into #3

@drammock drammock closed this May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants