-
Notifications
You must be signed in to change notification settings - Fork 2
Culling packages #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
drammock
merged 105 commits into
scientific-python:main
from
matthew-brett:cull-packages
May 30, 2025
+942
−585
Merged
Changes from all commits
Commits
Show all changes
105 commits
Select commit
Hold shift + click to select a range
64777ea
Culling packages
matthew-brett 4074ed3
Remove Vista and MNE-specific GUI tests.
matthew-brett 6ffc064
Extend import check to all specs.
matthew-brett caf8b90
Remove darkdetect and qdarkstyle
matthew-brett d7ae7f4
Update versions
matthew-brett ed89291
Ruff reformatting
matthew-brett 5eb5055
update logos
drammock ad5883d
update copyright in license
drammock 6e65f09
WIP: update readme (some URLs TBD)
drammock e443d1e
update post-install scripts
drammock e5e9ca3
update pre- and post-install dialog text
drammock a74b6ac
fix folder name and prompt
drammock b3e6af6
update env var names
drammock df26d05
mne- ==> scientific-
drammock a95a1ee
more mne->scientific; reset version to 0.1.0
drammock 6c82ec8
update notebook test
drammock f5d1ed7
fix(?) workflow defs
drammock 0cfed07
Start sp-installer-menu
matthew-brett 11a1ee2
Remove some more packages
matthew-brett e31e566
A few more MNE_ references.
matthew-brett cd1a84a
Remove more uses of MNE, generalize name, var
matthew-brett b14450f
Do not use a missing png file.
matthew-brett 78ae736
Hardcode name and version in construct.yaml
matthew-brett dbf063a
Remove reference to .app
matthew-brett 3aee757
Remove as-yet-unbuilt package from environment.
matthew-brett 41ce625
Generalize local channel
matthew-brett cc4cff0
Try plumbing package build into GHA
matthew-brett 1935ff5
Make icons etc specific to scientific Python.
matthew-brett 4949a73
"A lot of changes picked up here"
matthew-brett c80dd6e
All sorts of hard-won wisdom.
matthew-brett f2e5413
Try fixes to Jupyter path.
matthew-brett 4c1922f
Try a more comprehensive clean.
matthew-brett 80cdbd2
Build package in custom local directory.
matthew-brett 2df35db
[autofix.ci] apply automated fixes
autofix-ci[bot] 1c997e0
Replace uses of MNE in tools
matthew-brett 9aafb61
Add back test for mac folder icon.
matthew-brett d0a16d1
Add back test for packages.
matthew-brett cbe1850
Remove QT check.
matthew-brett 6408e2d
[autofix.ci] apply automated fixes
autofix-ci[bot] 63ebdb2
Turn off code signing check for now.
matthew-brett 980cd60
Change name of output directory for tests.
matthew-brett ea3b209
misc cleanups
drammock 9bc9a7b
overhaul sysinfo script
drammock 851e43e
ruff
drammock d0956a8
overhaul sysinfo script
drammock 33daf04
cleanups
drammock 859d33d
more cleanups
drammock a4f46c0
make Makefile platform-aware (WIP)
drammock 3ef0a42
typo
drammock baa6d3b
clean thoroughly
drammock 0417c41
Try some fixes to counts for Linux desktop
matthew-brett 6dc2317
Fix quotes for macOS postinstall.
matthew-brett 538c0e7
Remove set to default QT backend.
matthew-brett 4f7a102
standardize names, fix URLs, remove generic launcher
drammock ea81bb7
add (and use) jupyter icons
drammock 8aab8f2
fix one test
drammock 4fe5b9b
Remove version from output directory.
matthew-brett 63d5425
Move applications into Scientific-Python folder.
matthew-brett 8cdb7fb
Copy Jupyter stuff into Menu folder.
matthew-brett 32eb78d
Stop opening double terminals.
matthew-brett d25b51f
Attempt to fix test for apps in Application folder.
matthew-brett fd4cc04
[autofix.ci] apply automated fixes
autofix-ci[bot] 3a6d5b3
Remove dev check (test removed a while ago).
matthew-brett b9e2385
fix another test
drammock c80e731
Move installation prefix.
matthew-brett 53f7c38
Fixes for test_imports
matthew-brett c6d3362
Adapt GUI test.
matthew-brett efc3069
[autofix.ci] apply automated fixes
autofix-ci[bot] 91e470a
Directly check package name rather than build number.
matthew-brett d84a006
Do no ask for sp-installer-menu build string.
matthew-brett 1858f53
Fix for want_versions
matthew-brett da4f79c
Assert actual backend on Windows (QTAgg)
matthew-brett b0c6855
Revert "Stop opening double terminals."
matthew-brett fb8f0df
In fact Linux seems to use QTAgg, like Windows.
matthew-brett 32f42b2
Move terminal-ness to platform specific parts.
matthew-brett 7e40243
fix clean recipe on Linux
drammock 0fd3594
WIP test fixes
drammock 40b9963
Remove reference to MNE
matthew-brett 91f21ea
Set Jupyter paths to avoid user's setup.
matthew-brett 75352ae
Ignore ipynb_checkpoints
matthew-brett db4b841
Add use to license.
matthew-brett 1d33a10
[autofix.ci] apply automated fixes
autofix-ci[bot] 7ceb5a9
Slightly rewrite license.
matthew-brett 47abb53
Make spi_sys_info executable.
matthew-brett f203422
Fix application directory opened by install.
matthew-brett f7b451a
Try enabling post-install sys-info.
matthew-brett 5e05d23
Preserve permissions in copy
matthew-brett 7e0d695
[autofix.ci] apply automated fixes
autofix-ci[bot] 1c3bb07
Workaround for conda activation error.
matthew-brett aac7c8e
[autofix.ci] apply automated fixes
autofix-ci[bot] d6619e9
Refine, comment on and fix logic for .bat init
matthew-brett c605777
Refactor Windows prompt activation.
matthew-brett e237bf3
use stdout instead of browser for post-install sysinfo
drammock 782690b
docstring lint; wording tweak
drammock 78c320a
whitespace
drammock 6dc0750
remove cruft comment
drammock 72e4544
Update sp-installer-menu/LICENSE.txt
drammock 0cf7452
[autofix.ci] apply automated fixes
autofix-ci[bot] be8494a
Update README.md
drammock 1bd472d
remove no-test flag on menu package build
drammock 8754bf5
update mac folder icon
drammock dfb6c62
comment out installer screenshot in README
drammock 51cf331
make the "install" recipe platform-specific
drammock 6a90ad2
change windows runners (2019 is almost EOL)
drammock 6b104bc
restore --no-test flag on windows build
drammock File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,3 +7,5 @@ tests/.joblib_cache | |
| .pytest_cache | ||
| .DS_Store | ||
| __pycache__ | ||
| conda-bld/ | ||
| .ipynb_checkpoints/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| # Makefile targets for local build steps on Mac. | ||
| SHELL := bash | ||
| MENU_PKG_NAME=sp-installer-menu | ||
| ROOT_PREFIX=$(shell conda config --show root_prefix | cut -d ' ' -f 2) | ||
| ENV_PKGS=$(ROOT_PREFIX)/pkgs | ||
|
|
||
| UNAME := "$(shell uname -s)" | ||
| ifeq ($(findstring Linux,$(UNAME)),Linux) | ||
| MACHINE=Linux | ||
| else ifeq ($(findstring Darwin,$(UNAME)),Darwin) | ||
| MACHINE=macOS | ||
| else ifeq ($(findstring MINGW64_NT,$(UNAME)),MINGW64_NT) | ||
| MACHINE=Windows | ||
| else ifeq ($(FINDSTRING MSYS_NT,$(UNAME)),MSYS_NT) | ||
| MACHINE=Windows | ||
| else | ||
| MACHINE="UNKNOWN:$(UNAME)" | ||
| endif | ||
|
|
||
| all: menu-pkg installer | ||
|
|
||
| menu-pkg: | ||
| conda-build $(MENU_PKG_NAME) --no-anaconda-upload --croot conda-bld | ||
|
|
||
| installer: | ||
| constructor recipes/scientific-python | ||
|
|
||
| install: | ||
| @if [[ $(MACHINE) == "macOS" ]]; then \ | ||
| installer -pkg Scientific-Python-*.pkg -target CurrentUserHomeDirectory; \ | ||
| elif [[ $(MACHINE) == "Linux" ]]; then \ | ||
| sh ./Scientific-Python-*-Linux.sh; \ | ||
| elif [[ $(MACHINE) == "Windows" ]]; then \ | ||
| echo "TODO add install command for Windows"; \ | ||
| fi | ||
|
|
||
| clean: | ||
| @rm -rf conda-bld | ||
| @rm -rf ~/.conda/constructor/*/$(MENU_PKG_NAME)* | ||
| @if [[ $(MACHINE) == "macOS" ]]; then \ | ||
| rm -rf ~/Applications/*Scientific*; \ | ||
| rm -f Scientific-Python-*.pkg; \ | ||
| elif [[ $(MACHINE) == "Linux" ]]; then \ | ||
| rm -rf $(HOME)/Scientific-Python; \ | ||
| rm -f ./Scientific-Python-*.sh; \ | ||
| rm -f $(HOME)/.local/share/applications/scientific-python-*.desktop; \ | ||
| elif [[ $(MACHINE) == "Windows" ]]; then \ | ||
| echo "TODO add command to cleanup icons on Windows"; \ | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ | |
| \pard\pardeftab720\partightenfactor0 | ||
| \f1\b0 \cf2 \ | ||
| Copyright \'a9 MNE-Python Developers\ | ||
| Copyright \'a9 Scientific Python Developers\ | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should acknowledge "MNE-Python Developers" here too, no? |
||
| All rights reserved.\ | ||
| \ | ||
| Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:\ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| BSD 3-Clause License | ||
|
|
||
| Copyright (c) MNE-Python Developers | ||
| Copyright (c) Scientific Python Developers | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto on acknowledging MNE-Python devs too |
||
| All rights reserved. | ||
|
|
||
| Redistribution and use in source and binary forms, with or without | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.