fix: update minio interface to be compatible with future versions #1527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Seems like they are working on it minio/minio-py#1535 I'll wait to see if they solve it by tomorrow, and I'll change the pin to <8 to be a bit less restrictive. |
ariostas
changed the title
Collaborator
Author
|
@ianna could you review this again? It turned out that the breaking changes were pretty minor, so by adding explicit kwargs we can support both the old and new interfaces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minio is preparing to release v8.0.0 with some breaking changes. They already (seemingly accidentally) released v7.2.19 with some of those breaking changes. So I'm pinning it to v7.2.18 for now, and we'll move on to v8 once it's been out for a little while.
Here are some relevant links:
minio/minio-py#1532
minio/minio-py#1533
minio/minio-py#1505 (comment)
minio/minio-py#1531