Skip to content

Fix bug in angle_to_sexigesimal - angles seem to be doubled #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix bug in angle_to_sexigesimal - angles seem to be doubled #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
045f035
add test for buggy function
nikoladze Jul 12, 2025
2ea19b9
fix buggy function by (360 degrees instead of 180)
nikoladze Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion participants/scipy_003/pr_tutorial/buggy_function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def angle_to_sexigesimal(angle_in_degrees, decimals=3):
if math.floor(decimals) != decimals:
raise OSError('decimals should be an integer!')

hours_num = angle_in_degrees*24/180
hours_num = angle_in_degrees*24/360
hours = math.floor(hours_num)

min_num = (hours_num - hours)*60
Expand Down
4 changes: 4 additions & 0 deletions participants/scipy_003/pr_tutorial/tests/test_buggy_function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
from pr_tutorial.buggy_function import angle_to_sexigesimal

def test_angle_to_sexigesimal():
assert angle_to_sexigesimal(360) == "24:0:0.000"