Skip to content

CI: test on python 3.8, too #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2025
Merged

CI: test on python 3.8, too #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50c222a
CI: test on python 3.8, too
ev-br Aug 8, 2025
5f6e7df
BUG: use Union in a type annotation
ev-br Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pip.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
python-version: ['3.11', '3.12', '3.13']
python-version: ['3.8', '3.11', '3.12', '3.13']
numpy: ['"numpy<2.0"', "numpy"]
os: [ubuntu-latest]
pytest: [pytest]
Expand Down
4 changes: 2 additions & 2 deletions scipy_doctest/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import inspect
from contextlib import contextmanager

from typing import Sequence
from typing import Sequence, Union

from importlib.metadata import version as get_version, PackageNotFoundError
from packaging.requirements import Requirement
Expand Down Expand Up @@ -259,7 +259,7 @@ def get_public_objects(module, skiplist=None):
return (items, names), failures


def is_req_satisfied(req_strs: str | Sequence[str]) -> bool:
def is_req_satisfied(req_strs: Union[str, Sequence[str]]) -> bool:
""" Check if all PEP 508-compliant requirement(s) are satisfied or not.
"""
req_strs = [req_strs] if isinstance(req_strs, str) else req_strs
Expand Down