Skip to content

Allow tags per event #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 22, 2025
Merged

Allow tags per event #1549

merged 20 commits into from
Jul 22, 2025

Conversation

jespino
Copy link
Contributor

@jespino jespino commented Jul 20, 2025

This is my proposal to include tags for events.

For now all the tags for 2025 and after were generated by AI, so I'm not sure how accurate they are, but they look fairly accurate for me. I can share the script to generate tags if you want but it would require an Anthropic Claude subscription to execute the script.

I think the final result is very cool, I left it visually lightweight, but I don't want to make it more colorful, applying different colors per type of tag, or things like that.

imagen

@scraly
Copy link
Owner

scraly commented Jul 20, 2025

Interesting
About the filter I imagine a "tag" section and inside the tag you can filter by language, technology, type...

Another idea is the ability to display or not tags. Users should be able to add or not the displaying of the tags I think.

@jespino
Copy link
Contributor Author

jespino commented Jul 20, 2025

About the filter, yes, I think I can improve that. About the hability of enable/disable tags display, I don't know what is the real value of not showing the tags. I can do it, but what is the use case?

@scraly
Copy link
Owner

scraly commented Jul 20, 2025

For the people using the website since several years, they just want to keep a simple usage and simple reading.
So if they want to display tags they can but if they want to not show them, because they don't have the needs, they can too.

I think the language can be very helpful 💪.
Tech and topic can be helpful also (can we mix them in one filter?).
About type of event I don't think it's really useful.

@scraly
Copy link
Owner

scraly commented Jul 20, 2025

Moreover, the filter is truncated in the listView
image

So is it possible for you to display the filter on the top?

@jespino
Copy link
Contributor Author

jespino commented Jul 20, 2025

Now I improved the tags selector, it is way more compact, so it shouldn't be a problem for the list view. Also is more ergonomic. I removed the type tag, and I added the enable/disable tags. I left it enable by default for easy discovery, but allow people to disable it to go back to the clean interface.

I have a question, should I show the tags based filter even if you have the tags disabled? Now it is hiding also the tags filter, but I don't know what do you prefer.

@scraly
Copy link
Owner

scraly commented Jul 20, 2025

The tag selector is better, thanks! 💪

FYI In the listView, the sorting section is truncated now for me:
image

calendarView:
The tags are displayed differentely than in the listView
image

About the tag icon, is it possible to display it above or below the filter icon?
(Even if i knew you had this feature, I did not find it ... until I search it everywhere in the page, so maybe put it near the filter icon can help people to find this new feature?)

@scraly
Copy link
Owner

scraly commented Jul 20, 2025

Another behavior:
In the listView, when I click on a topic, now the filter is automatically set to this topic (cool), but when I click again is it possible to unfilter?
Moreover, if I go to another view, cfpView for example, the filter is still defined on a topic BUT I can't disable the filter on this tag in the filter section:

Enregistrement.de.l.ecran.2025-07-20.a.22.00.42.mov

@scraly
Copy link
Owner

scraly commented Jul 20, 2025

"I have a question, should I show the tags based filter even if you have the tags disabled? Now it is hiding also the tags filter, but I don't know what do you prefer."

-> about that, it's the wanted behavior, thanks :).

@jespino
Copy link
Contributor Author

jespino commented Jul 21, 2025

I think I have address everything there. The filters now is scrollable (if it is needed), the tags are togglable. The button of the tags on/off is with the filters, the calendar view tags are now shown like in Cfp list view tags.

Everything should be working as expected now. Let' me know if you need something else to change.

@scraly
Copy link
Owner

scraly commented Jul 21, 2025

Perfecto ❤️

About the tags, is it possible to share your script also?
Moreover, in order to be accurate, now the script need to be execute recurrently

@jespino
Copy link
Contributor Author

jespino commented Jul 22, 2025

The problem with the script being executed recurrently is that you need an ANTHROPIC_API_KEY environment variable set to the right configuration. For now, I'm going to put the script there to automatically generate things, but you need to execute it manually. Then you can decide to run this periodically as part of the CI. Also, another option is to make the CI fail if there is no entry in the TAGS file for the events in the future; that way, you can "force" that everything is at least purposely "ignored".

@scraly scraly merged commit 62c7fcf into scraly:main Jul 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants