fix: assume current year for formats without it #1288
Merged
+120
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTFSvolume
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1288 +/- ##
==========================================
+ Coverage 96.58% 96.60% +0.02%
==========================================
Files 235 235
Lines 2866 2886 +20
==========================================
+ Hits 2768 2788 +20
Misses 98 98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Seems like you need a minor change for Python 3.10 support in tests. |
BoboTiG
reviewed
Oct 27, 2025
|
|
||
| @parameterized.expand( | ||
| [ | ||
| param(date_string="oct 14", fmt=r"%m %d"), |
There was a problem hiding this comment.
Maybe adding more cases here? Like "14-October-2025" which also triggers the warning on my side; and at least the original test case from the issue: "2024-11-27"?
Contributor
Author
There was a problem hiding this comment.
Done. I added them to the parser tests
Contributor
Author
|
Fixed compat issues with python 3.9/3.10 and added some additional tests |
|
Works for me, thanks @NTFSvolume 🥂 |
Gallaecio
approved these changes
Oct 28, 2025
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.