use sink name and command name for consule lock key #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why this change? |
|
I wanted to have different mixes of sinks for the same command, for example writing job changes to http and to mongo at the same time |
|
@jippi I'll leave merging/releasing to you :) |
|
I do realize its a breaking change, but it think its a needed one |
|
@amfern can you make it so it defaults to the current value, but you can override it by |
|
yes |
ilyaiqoqo
force-pushed
the
use-sink-type-as-lock-key-too
branch
from
860cc6f to
1b26c2c
Compare
|
@jippi update the PR |
|
Hi, this now has a merge conflict :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.