refactor: ♻️ rename to properties in read_json()
#169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwjohnst86
changed the base branch from
feat/implement-error-true-argument
to
main
Member
Author
|
I messed up, this has commits from another PR. Will wait until that one is merged before converting this one to be ready for review. |
Contributor
|
Sorry, are you waiting on me for this? |
…package into refactor/rename-to-properties-in-read-json
Member
Author
|
@martonvago yes! Or someone 😛 |
martonvago
requested changes
Nov 7, 2025
| """ | ||
| try: | ||
| descriptor: Any = loads(path.read_text()) | ||
| properties: dict[str, Any] = loads(path.read_text()) |
Contributor
There was a problem hiding this comment.
But the return type of loads is Any, right? So we can't assert here that it's a dict. (That's why we are checking it later on.)
Suggested change
| properties: dict[str, Any] = loads(path.read_text()) | |
| properties: Any = loads(path.read_text()) |
| ) from None # To hide the original traceback | ||
|
|
||
| if not isinstance(descriptor, dict): | ||
| if not isinstance(properties, dict): # pyright: ignore |
Contributor
There was a problem hiding this comment.
Suggested change
| if not isinstance(properties, dict): # pyright: ignore | |
| if not isinstance(properties, dict): |
Or what is it complaining about?
github-project-automation
bot
moved this from In Review
to In Progress
in Iteration planning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Very small fix to use
propertiesinread_json().Needs a quick review.
Checklist
just run-all