feat: ✨ handle grouped errors under resource fields #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonvago
commented
Oct 29, 2025
martonvago
commented
Oct 29, 2025
martonvago
commented
Oct 29, 2025
martonvago
commented
Oct 29, 2025
martonvago
commented
Oct 29, 2025
martonvago
commented
Oct 29, 2025
Contributor
Author
|
If we merge in #177, I will align this with that |
lwjohnst86
requested changes
Nov 3, 2025
Member
lwjohnst86
left a comment
lwjohnst86
left a comment
There was a problem hiding this comment.
Nice! Only some small comments
github-project-automation
bot
moved this from In Review
to In Progress
in Iteration planning
lwjohnst86
requested changes
Nov 4, 2025
Member
lwjohnst86
left a comment
lwjohnst86
left a comment
There was a problem hiding this comment.
Very small change to the error message
github-project-automation
bot
moved this from In Review
to In Progress
in Iteration planning
lwjohnst86
requested changes
Nov 5, 2025
github-project-automation
bot
moved this from In Review
to In Progress
in Iteration planning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a function for handling grouped errors under
$.resources[x].schema.fields[x].Here, the problem comes from the fact that each field type has its own sub-JSON-schema, and each one of these sub-schemas flags issues when the type of a field is not its own type. So, if a field has
type="number"and there is something wrong with the field, then the sub-schemas foryear,string, etc. will also flag issues. The goal is to flag issues only fornumber.Part of #15
Needs an in-depth review.
Checklist
just run-all