chore: 🔨 add commit linting via pre-commit #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
signekb
approved these changes
Oct 31, 2024
Member
signekb
left a comment
signekb
left a comment
There was a problem hiding this comment.
I don't know too much about this, but I'll approve to see how it plays out when it has been merged and sync'ed :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds pre-commit to the repos, which will auto-run commit linting before the commit message is finished.
After this is merged in and sync'ed with Sprout, the spaid command
spaid_setup_dev_workspacewill install everything for this to start working.Alternatively, this pre-commit will always run on PRs, and will throw an error if a commit message is wrong.
Closes #8, closes seedcase-project/team#89
This PR needs an in-depth review.