Skip to content

Conversation

@codchen
Copy link
Collaborator

@codchen codchen commented Dec 30, 2025

Describe your changes and provide context

ethers would attempt to convert any string type field in a call response to unicode, which would fail for ConsensusPubkey since it contains non-readable bytes. The fix is to change ConsensuPubkey's type from string to bytes so that ethers don't attempt to convert it.

Testing performed to validate your change

test with ethers

@github-actions
Copy link

github-actions bot commented Dec 30, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJan 2, 2026, 6:18 PM

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.29%. Comparing base (e6cb591) to head (736110c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2646      +/-   ##
==========================================
+ Coverage   43.71%   46.29%   +2.57%     
==========================================
  Files        1902     1235     -667     
  Lines      158679   108109   -50570     
==========================================
- Hits        69372    50044   -19328     
+ Misses      82918    53468   -29450     
+ Partials     6389     4597    -1792     
Flag Coverage Δ
sei-chain 45.69% <0.00%> (+<0.01%) ⬆️
sei-cosmos ?
sei-db 69.06% <0.00%> (ø)
sei-tendermint 47.28% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 691 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants