Refactors the XdpDevice::open procedure to delegate more clearly. #1995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ametetarized versions. - Renamed initConfig to populateConfigDefaults so it only updates the config and does not write to the member variable config. - Fixed bug where open(XdpDeviceConfigration) overload replaced the configuration before checking if the device is open.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1995 +/- ##
==========================================
- Coverage 83.41% 83.40% -0.01%
==========================================
Files 311 311
Lines 55026 55014 -12
Branches 11777 11860 +83
==========================================
- Hits 45900 45886 -14
+ Misses 7868 7839 -29
- Partials 1258 1289 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initConfigtopopulateConfigDefaultsso it only updates the config and does not write to the member variable config.XdpDevice::open(XdpDeviceConfiguration& config)on already open device replaces the configuration. #1994