Skip to content

fix: optimize BigInt usage in hash function #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

fix: optimize BigInt usage in hash function #1003

merged 1 commit into from
Aug 6, 2025
+1 −1

Conversation

reallesee
Copy link
Contributor

@reallesee reallesee commented Jul 12, 2025 •
edited
Loading

Description

Replace BigInt(8) with 8n literal in bit shift operation to improve performance by avoiding unnecessary BigInt object creation.

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn format and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@reallesee reallesee requested a review from a team as a code owner July 12, 2025 17:03
vplasencia
vplasencia approved these changes Aug 6, 2025
View reviewed changes
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you very much @reallesee

@vplasencia vplasencia merged commit 81dbf86 into semaphore-protocol:main Aug 6, 2025
4 checks passed
@gitpoap-bot gitpoap-bot
Copy link

gitpoap-bot bot commented Aug 6, 2025

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2025 Semaphore Contributor:

GitPOAP: 2025 Semaphore Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vplasencia vplasencia vplasencia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reallesee @vplasencia