Skip to content
Open
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 80 additions & 10 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ jobs:
org.opencontainers.image.vendor=SemaphoreUI
maintainer=Semaphore UI <support@semaphoreui.com>
tags: |
type=raw,value=${{ github.ref_name }}
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Retain v-prefixed Docker tags

The existing release job used type=raw,value=${{ github.ref_name }} which emitted Docker tags like v2.10.3. The new configuration switches to type=semver,pattern={{version}} (and the same pattern in the other metadata steps) without adding prefix=v. docker/metadata-action strips the leading v from semver versions, so a release tagged v2.10.3 will now publish images 2.10.3 and 2.10 instead of v2.10.3/v2.10. This silently drops the tags that existing deployments pin to (semaphoreui/semaphore:vX.Y.Z), so pulls will fail once the change ships. Add prefix=v (or switch back to {{raw}}) to preserve the current tag names, and apply the same fix to the variant metadata blocks.

Useful? React with 👍 / 👎.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex fix it

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

  • Added prefix=v to every semver-based Docker metadata tag so both base and variant images continue publishing their existing v-prefixed tag names. .github/workflows/release.ymlL84-L245

Testing

  • ⚠️ Tests not run (not requested)

View task →

flavor: |
latest=true

Expand All @@ -107,6 +108,23 @@ jobs:
labels: ${{ steps.server.outputs.labels }}
tags: ${{ steps.server.outputs.tags }}

- name: Server Ansible meta
id: server_ansible
uses: docker/metadata-action@v5
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
images: |
semaphoreui/semaphore
labels: |
org.opencontainers.image.vendor=SemaphoreUI
maintainer=Semaphore UI <support@semaphoreui.com>
tags: |
type=semver,pattern={{version}},suffix=-ansible2.16.5
type=semver,pattern={{major}}.{{minor}},suffix=-ansible2.16.5
flavor: |
latest=true
suffix=-ansible2.16.5

- name: Server build with Ansible 2.16.5
uses: docker/build-push-action@v5
with:
Expand All @@ -117,8 +135,25 @@ jobs:
file: deployment/docker/server/Dockerfile
platforms: linux/amd64,linux/arm64 # ,linux/arm/v6
push: ${{ github.event_name != 'pull_request' }}
labels: ${{ steps.server.outputs.labels }}
tags: semaphoreui/semaphore:${{ github.ref_name }}-ansible2.16.5
labels: ${{ steps.server_ansible.outputs.labels }}
tags: ${{ steps.server_ansible.outputs.tags }}

- name: Server PowerShell meta
id: server_powershell
uses: docker/metadata-action@v5
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
images: |
semaphoreui/semaphore
labels: |
org.opencontainers.image.vendor=SemaphoreUI
maintainer=Semaphore UI <support@semaphoreui.com>
tags: |
type=semver,pattern={{version}},suffix=-powershell7.5.0
type=semver,pattern={{major}}.{{minor}},suffix=-powershell7.5.0
flavor: |
latest=true
suffix=-powershell7.5.0

- name: Server build with PowerShell 7.5.0
uses: docker/build-push-action@v5
Expand All @@ -132,8 +167,8 @@ jobs:
file: deployment/docker/server/powershell/Dockerfile
platforms: linux/amd64
push: ${{ github.event_name != 'pull_request' }}
labels: ${{ steps.server.outputs.labels }}
tags: semaphoreui/semaphore:${{ github.ref_name }}-powershell7.5.0
labels: ${{ steps.server_powershell.outputs.labels }}
tags: ${{ steps.server_powershell.outputs.tags }}



Expand All @@ -148,7 +183,8 @@ jobs:
org.opencontainers.image.vendor=SemaphoreUI
maintainer=Semaphore UI <support@semaphoreui.com>
tags: |
type=raw,value=${{ github.ref_name }}
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}
flavor: |
latest=true

Expand All @@ -163,6 +199,23 @@ jobs:
labels: ${{ steps.runner.outputs.labels }}
tags: ${{ steps.runner.outputs.tags }}

- name: Runner Ansible meta
id: runner_ansible
uses: docker/metadata-action@v5
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
images: |
semaphoreui/runner
labels: |
org.opencontainers.image.vendor=SemaphoreUI
maintainer=Semaphore UI <support@semaphoreui.com>
tags: |
type=semver,pattern={{version}},suffix=-ansible2.16.5
type=semver,pattern={{major}}.{{minor}},suffix=-ansible2.16.5
flavor: |
latest=true
suffix=-ansible2.16.5

- name: Runner build with Ansible 2.16.5
uses: docker/build-push-action@v5
with:
Expand All @@ -173,8 +226,25 @@ jobs:
file: deployment/docker/runner/Dockerfile
platforms: linux/amd64,linux/arm64 #,linux/arm/v6
push: ${{ github.event_name != 'pull_request' }}
labels: ${{ steps.runner.outputs.labels }}
tags: semaphoreui/runner:${{ github.ref_name }}-ansible2.16.5
labels: ${{ steps.runner_ansible.outputs.labels }}
tags: ${{ steps.runner_ansible.outputs.tags }}

- name: Runner PowerShell meta
id: runner_powershell
uses: docker/metadata-action@v5
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
images: |
semaphoreui/runner
labels: |
org.opencontainers.image.vendor=SemaphoreUI
maintainer=Semaphore UI <support@semaphoreui.com>
tags: |
type=semver,pattern={{version}},suffix=-powershell7.5.0
type=semver,pattern={{major}}.{{minor}},suffix=-powershell7.5.0
flavor: |
latest=true
suffix=-powershell7.5.0

- name: Runner build with PowerShell 7.5.0
uses: docker/build-push-action@v5
Expand All @@ -188,5 +258,5 @@ jobs:
file: deployment/docker/server/powershell/Dockerfile
platforms: linux/amd64
push: ${{ github.event_name != 'pull_request' }}
labels: ${{ steps.runner.outputs.labels }}
tags: semaphoreui/runner:${{ github.ref_name }}-powershell7.5.0
labels: ${{ steps.runner_powershell.outputs.labels }}
tags: ${{ steps.runner_powershell.outputs.tags }}