feat: trait for signature and NCS impl over it #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrohba1
changed the title
pedrohba1
force-pushed
the
hs2s2-library-impl
branch
from
7afa786 to
672e532
Compare
Signed-off-by: pedro bufulin <pedro@semiotic.ai>
Signed-off-by: pedro bufulin <pedro@semiotic.ai>
if using the BN254, P::G1 is equivalent to Bn254::G1Projective Signed-off-by: pedro bufulin <pedro@semiotic.ai>
Signed-off-by: pedro bufulin <pedro@semiotic.ai>
Signed-off-by: pedro bufulin <pedro@semiotic.ai>
Signed-off-by: pedro bufulin <pedro@semiotic.ai>
use only first generator for signing and verifying messages, test with max_lanes amount of messages Signed-off-by: pedro bufulin <pedro@semiotic.ai>
… tags as ScalarField Signed-off-by: pedro bufulin <pedro@semiotic.ai>
Signed-off-by: pedro bufulin <pedro@semiotic.ai>
Signed-off-by: pedro bufulin <pedro@semiotic.ai>
pedrohba1
force-pushed
the
hs2s2-library-impl
branch
from
672e532 to
d966c4b
Compare
cbehn1
reviewed
Dec 17, 2024
cbehn1
requested changes
Dec 17, 2024
Signed-off-by: pedro bufulin <pedro@semiotic.ai>
Signed-off-by: pedro bufulin <pedro@semiotic.ai>
Signed-off-by: pedro bufulin <pedro@semiotic.ai>
Signed-off-by: pedro bufulin <pedro@semiotic.ai>
pedrohba1
force-pushed
the
hs2s2-library-impl
branch
from
a6fa8b0 to
b24557c
Compare
cbehn1
approved these changes
Dec 19, 2024
cbehn1
left a comment
cbehn1
left a comment
There was a problem hiding this comment.
Everything currently looks good to me.
severiano-sisneros
requested changes
Dec 19, 2024
Collaborator
severiano-sisneros
left a comment
severiano-sisneros
left a comment
There was a problem hiding this comment.
Looks good. Couple changes I think would be good: update the h2s2 function signature to accept allocation_id as an input rather than calculate it and return it, and use the HashToCurve trait provided by ark-ec to when hashing messages to curve points, rather than implementing our own.
Signed-off-by: pedro bufulin <pedro@semiotic.ai>
also refactor curve and hasher types in test Signed-off-by: pedro bufulin <pedro@semiotic.ai>
Signed-off-by: pedro bufulin <pedro@semiotic.ai>
severiano-sisneros
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.