ReadID3v2Frames, ReadID3v1Frames, WriteID3v2Frames #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…null pointer. this is consistent with taglib_file_write_tags
Contributor
Author
|
checked the pr for image tags #5. I didn't see any major conflicts or cross development. |
sentriz
force-pushed
the
master
branch
4 times, most recently
from
9d63b84 to
0f84fcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functions for for reading and writing mp3 ID3 frames.
This PR is NOT ready for review. I forked it from #13 to make my life easier during development. That should merge first.
I also haven't looked at the pr for image tags yet. #5 There might be some cross development there. I'll have to check.
tests have not yet been developed either
Why?
It turns out Ratings on windows doesn't use the rating "standard" tag. Instead using POPM frames. I know of at least 3 different variations of POPM frames in use between win 10 (probably 11 as well) permissions dialog, Mp3Tag, and MediaMonkey. In order to properly read and set those frames the taglib lower level functions had to be exposed. I also exposed the id3v1 read frame so that they can be compared. It is possible for an application to mangle writes to ID3 and only update id3v1 or id3v2 and not both.