Recommend container naming convention for runtime implementations #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBBianchi
added
change: documentation
- Added a note in the DSL reference specifying a recommended naming convention for container tasks in runtime implementations. Closes serverlessworkflow#1055 Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
JBBianchi
force-pushed
the
fix-1055-container-naming-recommandation
branch
from
aad7cab to
9ffe035
Compare
cdavernas
reviewed
Jan 10, 2025
Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io> Co-authored-by: Charles d'Avernas <charles.davernas@neuroglia.io>
JBBianchi
force-pushed
the
fix-1055-container-naming-recommandation
branch
from
d32c6a1 to
07143cc
Compare
ricardozanini
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
@cdavernas, you also need to approve it. I made a few changes to fit the text inside the box and a small grammar nitpick.
- See comment serverlessworkflow#1061 (review) Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
cdavernas
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please specify parts of this PR update:
Discussion or Issue link:
#1055
What this PR does:
Adds a note in the DSL reference specifying a recommended naming convention for container tasks in runtime implementations.
Additional information: