Skip to content

Document schema validation order #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 49 commits into from
Aug 30, 2024
Merged

Document schema validation order #982

merged 49 commits into from
Aug 30, 2024

Conversation

matthias-pichler
Copy link
Collaborator

Signed-off-by: Matthias Pichler m.pichler@warrify.com

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:

#981

What this PR does:

I extended the data flow diagram with validation steps and rewrote the Data Flow section to acurately represent the execution order

Additional information:

cdavernas
cdavernas approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look awesome, many thanks man!!! ❤️

@cdavernas cdavernas changed the title docs: document schema validation order Document schema validation order Aug 21, 2024
@cdavernas cdavernas added change: fix Something isn't working. Impacts in a minor version change. change: documentation Improvements or additions to documentation. It won't impact a version change. change: feature New feature or request. Impacts in a minor version change labels Aug 21, 2024
@cdavernas cdavernas added this to the v1.0.0 milestone Aug 21, 2024
@cdavernas cdavernas removed the change: feature New feature or request. Impacts in a minor version change label Aug 21, 2024
ricardozanini
ricardozanini reviewed Aug 21, 2024
View reviewed changes
matthias-pichler and others added 20 commits August 29, 2024 15:35
@matthias-pichler
docs: document schema validation order
8bc3387 
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@matthias-pichler @ricardozanini
Update dsl.md
d33c030 
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@matthias-pichler @ricardozanini
Update dsl.md
bac10de 
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@matthias-pichler @ricardozanini
Update dsl.md
d5cf2e1 
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@matthias-pichler @ricardozanini
Update dsl.md
7c5f93c 
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@matthias-pichler @ricardozanini
Update dsl.md
e446cba 
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@matthias-pichler @ricardozanini
Update dsl.md
cc76e44 
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@matthias-pichler @ricardozanini
Update dsl.md
1f2e32a 
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@matthias-pichler @ricardozanini
Update dsl.md
672f3e1 
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@matthias-pichler @ricardozanini
Update dsl.md
82f22b8 
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@matthias-pichler @ricardozanini
Update dsl.md
bb21b64 
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @matthias-pichler
- Refactor the OAuth2 authentication policy
f99660e 
- Add the OIDC authentication policy
- Add the schema for the Digest authentication

Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @matthias-pichler
Fixes examples
1f99242 
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @ricardozanini @matthias-pichler
Update dsl-reference.md
6c5078e 
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @ricardozanini @matthias-pichler
Update dsl-reference.md
9c35228 
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @matthias-pichler
Added examples
14f99f3 
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @matthias-pichler
Fixed call, raise and try features
565de72 
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @matthias-pichler
Adds managing-github-issues and managing-ev-charging-stations use cases
5155668 
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @matthias-pichler
- Documented the difference between an event-driven schedule and a st…
a8123e6 
…artup listen task

- Added examples to document event-driven and cron schedules

Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @matthias-pichler
Added an event-driven subsection to scheduling to explain expected wo…
3ada408 
…rkflow input

Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
cdavernas and others added 23 commits August 29, 2024 15:35
@cdavernas @ricardozanini @matthias-pichler
Update dsl.md
5e112d3 
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @ricardozanini @matthias-pichler
Update dsl.md
92d845c 
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @matthias-pichler
Completes the EV charging station use case
8ef3540 
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @matthias-pichler
- Added a new README.md to the examples directory
805ce49 
- Fixed and renamed examples
- Added new examples

Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @matthias-pichler
Fixes the schema and docs to make the error.instance property optio…
82cf7ab 
…nal to authors

Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @matthias-pichler
Fixed the examples
c8e094a 
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @matthias-pichler
Fixed examples
f8fd119 
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @matthias-pichler
Fixed examples
155a76f 
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @matthias-pichler
Fixes the httpCall.with.body to not be restrict its type to object
0bbc40a 
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @matthias-pichler
Added new examples
70d5d1d 
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @matthias-pichler
Fix examples
dc371ca 
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @matthias-pichler
Fixed the schema to allow ISO 8601 duration expressions
7ae6cbe 
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @matthias-pichler
Added a new use case
2b5d4cf 
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @ricardozanini @matthias-pichler
Update examples/README.md
a27612b 
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @ricardozanini @matthias-pichler
Update examples/README.md
e057780 
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @ricardozanini @matthias-pichler
Update examples/README.md
ea13e79 
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @ricardozanini @matthias-pichler
Update use-cases/README.md
f7cab2b 
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @ricardozanini @matthias-pichler
Update use-cases/automated-data-backup/README.md
dbcf908 
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @ricardozanini @matthias-pichler
Update use-cases/README.md
60d8dc1 
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @ricardozanini @matthias-pichler
Update use-cases/managing-ev-charging-stations/README.md
ec84165 
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @ricardozanini @matthias-pichler
Update use-cases/managing-github-issues/README.md
35f3878 
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @ricardozanini @matthias-pichler
Update use-cases/managing-github-issues/README.md
a1c1f8b 
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas @ricardozanini @matthias-pichler
Update use-cases/multi-agent-ai-content-generation/README.md
1965a84 
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@matthias-pichler matthias-pichler force-pushed the schema-validation-order branch from 508fbef to 1965a84 Compare August 29, 2024 15:36
@cdavernas cdavernas merged commit c4daa76 into serverlessworkflow:main Aug 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

@cdavernas cdavernas cdavernas approved these changes

Assignees

@ricardozanini ricardozanini

Labels
change: documentation Improvements or additions to documentation. It won't impact a version change. change: fix Something isn't working. Impacts in a minor version change.
Projects
Progress Tracker
Status: Done
Milestone
v1.0.0-alpha3
Development

Successfully merging this pull request may close these issues.
3 participants
@matthias-pichler @ricardozanini @cdavernas