Add custom parser and more features #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fix - selector with no class. Improve performance - only call parseTableData() once - Removed getHighestColumnCount () and getObjectLength() functions. Using Object.keys(data).length property. Features: - toggle table header, row numbers - set initial row number value - set table width - custom parser function - toggle parse headers, row numbers - choose columns to parse - added title and footer - debug parameter, show all indexes on all cells
- Close tr tag - isHead flag inside parser function was wrong
fix error when showTableRowNumber is true and no parser is present. missing value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The opened enhancement pull request has bugs on index values on parser function.
I started to fix it and really liked this plug in, so I made some more features.
If you merge, please note that I updated the readme links to my github (still mention your project), so watch out for that.
Features:
Bug fix
Improve performance