Add RBS type signatures for error classes #2022
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add RBS type signatures for all error-related classes to complete type coverage for the gem.
Changes Made
ReactOnRails::Errorbase classReactOnRails::JsonParseErrorwith error context methodsReactOnRails::PrerenderErrorwith detailed rendering infoReactOnRails::SmartErrorwith actionable suggestionssig/react_on_rails.rbsfileClasses Added
sig/react_on_rails/error.rbs): Base error class inheriting from StandardErrorsig/react_on_rails/json_parse_error.rbs): JSON parsing error with contextsig/react_on_rails/prerender_error.rbs): Server rendering error with detailed infosig/react_on_rails/smart_error.rbs): Enhanced error with actionable suggestionsTesting
bundle exec rake rbs:validate)Impact
These signatures provide type information for error handling, helping developers catch type-related issues during development. This is purely additive and doesn't affect runtime behavior.
Fixes #1954
🤖 Generated with Claude Code
This change is