Skip to content

Conversation

@shiftkey
Copy link
Owner

@shiftkey shiftkey commented Feb 4, 2025

This PR may help resolve the CI issues by forking and updating both keytar and fs-admin to prebuild for the arm architecture on Linux.

I assume this all works, but haven't reviewed things closely.

For more details, see shiftkey/fs-admin#1 and shiftkey/node-keytar#1

@shiftkey shiftkey changed the base branch from development to linux February 4, 2025 12:50
@shiftkey shiftkey changed the title Shiftkey/building armv71 again get armv7l building again Feb 4, 2025
@shiftkey shiftkey force-pushed the shiftkey/building-armv71-again branch from dabc926 to 5381ff4 Compare February 4, 2025 14:21
@shiftkey shiftkey changed the title get armv7l building again get arm CI building again Feb 4, 2025
@shiftkey shiftkey changed the title get arm CI building again get arm CI building again Feb 4, 2025
@shiftkey shiftkey marked this pull request as ready for review February 4, 2025 16:50
@shiftkey shiftkey changed the title get arm CI building again get arm CI building again by forking archived packages Feb 4, 2025
@shiftkey shiftkey merged commit 599cce4 into linux Feb 4, 2025
9 checks passed
@shiftkey shiftkey deleted the shiftkey/building-armv71-again branch February 4, 2025 16:53
shiftkey added a commit that referenced this pull request Feb 4, 2025
* use forked fs-admin package with prebuilds for armv7l and other platforms

* doot

* attempt the second

* do we see anything different on node-gyp@11

* rename import to point to new package name

* bump to newer version

* also fix prebuilds for keytar to actually work
shiftkey added a commit that referenced this pull request Feb 5, 2025
* use forked fs-admin package with prebuilds for armv7l and other platforms

* doot

* attempt the second

* do we see anything different on node-gyp@11

* rename import to point to new package name

* bump to newer version

* also fix prebuilds for keytar to actually work
shiftkey added a commit that referenced this pull request Feb 5, 2025
* use forked fs-admin package with prebuilds for armv7l and other platforms

* doot

* attempt the second

* do we see anything different on node-gyp@11

* rename import to point to new package name

* bump to newer version

* also fix prebuilds for keytar to actually work
shiftkey added a commit that referenced this pull request Feb 5, 2025
* use forked fs-admin package with prebuilds for armv7l and other platforms

* doot

* attempt the second

* do we see anything different on node-gyp@11

* rename import to point to new package name

* bump to newer version

* also fix prebuilds for keytar to actually work
shiftkey added a commit that referenced this pull request Feb 5, 2025
* use forked fs-admin package with prebuilds for armv7l and other platforms

* doot

* attempt the second

* do we see anything different on node-gyp@11

* rename import to point to new package name

* bump to newer version

* also fix prebuilds for keytar to actually work
shiftkey added a commit that referenced this pull request Feb 5, 2025
* use forked fs-admin package with prebuilds for armv7l and other platforms

* doot

* attempt the second

* do we see anything different on node-gyp@11

* rename import to point to new package name

* bump to newer version

* also fix prebuilds for keytar to actually work
shiftkey added a commit that referenced this pull request Feb 9, 2025
* use forked fs-admin package with prebuilds for armv7l and other platforms

* doot

* attempt the second

* do we see anything different on node-gyp@11

* rename import to point to new package name

* bump to newer version

* also fix prebuilds for keytar to actually work
shiftkey added a commit that referenced this pull request Feb 9, 2025
* use forked fs-admin package with prebuilds for armv7l and other platforms

* doot

* attempt the second

* do we see anything different on node-gyp@11

* rename import to point to new package name

* bump to newer version

* also fix prebuilds for keytar to actually work
shiftkey added a commit that referenced this pull request Feb 9, 2025
* use forked fs-admin package with prebuilds for armv7l and other platforms

* doot

* attempt the second

* do we see anything different on node-gyp@11

* rename import to point to new package name

* bump to newer version

* also fix prebuilds for keytar to actually work
shiftkey added a commit that referenced this pull request Feb 9, 2025
* use forked fs-admin package with prebuilds for armv7l and other platforms

* doot

* attempt the second

* do we see anything different on node-gyp@11

* rename import to point to new package name

* bump to newer version

* also fix prebuilds for keytar to actually work
shiftkey added a commit that referenced this pull request Feb 9, 2025
* use forked fs-admin package with prebuilds for armv7l and other platforms

* doot

* attempt the second

* do we see anything different on node-gyp@11

* rename import to point to new package name

* bump to newer version

* also fix prebuilds for keytar to actually work
@AWESOME517
Copy link

قد يساعد هذا الطلب العام في حل مشكلات CI عن طريق التفرع والتحديث لكليهما keytarوالبناء fs-adminالمسبق للهندسة armالمعمارية على Linux.

أفترض أن كل هذا يعمل، لكنني لم أراجع الأمور عن كثب.

لمزيد من التفاصيل، راجع shiftkey/fs-admin#1 و shiftkey/node-keytar#1

تامين بالكامل مع ترجيع مع حذف المخترق فقط

@AWESOME517
Copy link

حذف وتامين وحمايه وحل المشاكل بالاجماع

shiftkey added a commit that referenced this pull request Mar 2, 2025
* use forked fs-admin package with prebuilds for armv7l and other platforms

* doot

* attempt the second

* do we see anything different on node-gyp@11

* rename import to point to new package name

* bump to newer version

* also fix prebuilds for keytar to actually work
shiftkey added a commit that referenced this pull request Mar 2, 2025
* use forked fs-admin package with prebuilds for armv7l and other platforms

* doot

* attempt the second

* do we see anything different on node-gyp@11

* rename import to point to new package name

* bump to newer version

* also fix prebuilds for keytar to actually work
shiftkey added a commit that referenced this pull request Mar 2, 2025
* use forked fs-admin package with prebuilds for armv7l and other platforms

* doot

* attempt the second

* do we see anything different on node-gyp@11

* rename import to point to new package name

* bump to newer version

* also fix prebuilds for keytar to actually work
theofficialgman pushed a commit to theofficialgman/desktop that referenced this pull request Oct 7, 2025
* use forked fs-admin package with prebuilds for armv7l and other platforms

* doot

* attempt the second

* do we see anything different on node-gyp@11

* rename import to point to new package name

* bump to newer version

* also fix prebuilds for keytar to actually work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants