Add LINUX_BUILD Definition to support linux without destructing others #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Discussions
I've read that Pull Request #149 in advance, and I thought that changing variable casing without deriving cases with any pre-processor check can cause potential build problem on other platforms.
Solution
I would like to append LINUX_BUILD macro check to distinguish Linux platform with others.
In most of the cases, Module installation on Linux, is using manual script called RunUAT.sh; so developers who are working on Linux should have been searched for script usage.
it is valid to conclude that the easiest solution to guide Linux Installation is to show the exact flag that is needed for proper builds.