Skip to content

Conversation

@macladson
Copy link
Member

Proposed Changes

  • Creates axum_utils which contain common functions and types
  • Begins migration of the VC HTTP API from warp to axum using warpdrive
  • Migrates both metrics servers to axum

@macladson macladson added work-in-progress PR is a work-in-progress HTTP-API labels Oct 23, 2025
@macladson macladson added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Oct 31, 2025
@dapplion
Copy link
Collaborator

Does warpdrive mess with SSE in any way? Have you tested them?

@macladson
Copy link
Member Author

Does warpdrive mess with SSE in any way? Have you tested them?

warpdrive has a basic example for SSE: https://github.com/macladson/warpdrive/blob/master/examples/sse.rs

Also if we find issues with it we can always migrate the SSE endpoints first

Copy link
Member

@eserilev eserilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For others reviewing:

  • warpdrive: a nice lil crate Mac put together to convert req/resp from warp to axum. This allows us to use the existing warp server as a fallback service. When reviewing this PR, you should also review this new crate
  • We should have buy-in from the team that this will be a "fast" migration from warp to axum in the validator client. We should not go multiple releases with this fallback mechanism in place in the validator client.
  • We might just want to migrate the SSE endpoint in this PR and not deal with the overhead of supporting axum <-> warp SSE functionality
  • We should run this on a Hoodi node and ensure were not seeing any degraded performance. Some metrics would be nice
  • According to claude we may have missing test coverage for the following endpoints
    GET /lighthouse/ui/health
    GET /lighthouse/ui/graffiti
    GET /lighthouse/beacon/health
    POST /lighthouse/beacon/update
    GET /lighthouse/logs
    DELETE /lighthouse/keystores

We should add test coverage for those sometime during this migration

@mergify
Copy link

mergify bot commented Nov 28, 2025

This pull request has merge conflicts. Could you please resolve them @macladson? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Nov 28, 2025
@mergify mergify bot added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Nov 28, 2025
@mergify
Copy link

mergify bot commented Dec 4, 2025

This pull request has merge conflicts. Could you please resolve them @macladson? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Dec 4, 2025
@mergify mergify bot added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HTTP-API ready-for-review The code is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants