-
Notifications
You must be signed in to change notification settings - Fork 939
Create axum_utils and begin VC HTTP API migration
#8280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
Conversation
|
Does warpdrive mess with SSE in any way? Have you tested them? |
Also if we find issues with it we can always migrate the SSE endpoints first |
eserilev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For others reviewing:
warpdrive: a nice lil crate Mac put together to convert req/resp from warp to axum. This allows us to use the existing warp server as a fallback service. When reviewing this PR, you should also review this new crate- We should have buy-in from the team that this will be a "fast" migration from warp to axum in the validator client. We should not go multiple releases with this fallback mechanism in place in the validator client.
- We might just want to migrate the SSE endpoint in this PR and not deal with the overhead of supporting axum <-> warp SSE functionality
- We should run this on a Hoodi node and ensure were not seeing any degraded performance. Some metrics would be nice
- According to claude we may have missing test coverage for the following endpoints
GET /lighthouse/ui/health
GET /lighthouse/ui/graffiti
GET /lighthouse/beacon/health
POST /lighthouse/beacon/update
GET /lighthouse/logs
DELETE /lighthouse/keystores
We should add test coverage for those sometime during this migration
|
This pull request has merge conflicts. Could you please resolve them @macladson? 🙏 |
|
This pull request has merge conflicts. Could you please resolve them @macladson? 🙏 |
Proposed Changes
axum_utilswhich contain common functions and typeswarpdriveaxum