Add nightly tests workflow to test prior forks #8319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
added
test improvement
|
Some required checks have failed. Could you please take a look @jimmygchen? 🙏 |
mergify
bot
added
waiting-on-author
jimmygchen
added
ready-for-review
mergify
bot
added
waiting-on-author
jimmygchen
added
ready-for-review
This comment was marked as outdated.
This comment was marked as outdated.
mergify
bot
added
waiting-on-author
This was referenced Oct 29, 2025
jimmygchen
added
ready-for-review
|
Some required checks have failed. Could you please take a look @jimmygchen? 🙏 |
mergify
bot
added
waiting-on-author
jimmygchen
removed
the
waiting-on-author
antondlr
approved these changes
Nov 18, 2025
Member
antondlr
left a comment
antondlr
left a comment
There was a problem hiding this comment.
great!
I could not inspect the outcome on your fork though (no access) but it LGTM
| on: | ||
| schedule: | ||
| # Run at 8:30 AM UTC every day | ||
| - cron: '30 8 * * *' |
Member
There was a problem hiding this comment.
is this just a time slot or is there reasoning behind it?
I think aiming for it to be ready by AUS AM is maybe a good idea?
also, UTC start of workday there may be heavier-than-average demand but I have no evidence of that
Member
Author
There was a problem hiding this comment.
yeah i looked at the timezones, I think it's more quiet on the lighthouse side , but maybe not on the anchor side?
Member
Author
There was a problem hiding this comment.
Thanks for the review! Let's try this out and we can move it if it doesn't work out
jimmygchen
added
ready-for-merge
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Once #8271 is merged, CI will only cover tests for
RECENT_FORKS(prev, current, next)To make sure functionalities aren't broken for prior forks, we run tests for these forks nightly. They can also be manually triggered.
Tested via manual trigger here: https://github.com/jimmygchen/lighthouse/actions/runs/18896690117