Skip to content

WIP: Add unit tests for rehydrator.ts #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

WIP: Add unit tests for rehydrator.ts #45

wants to merge 4 commits into from

Conversation

simon360
Copy link
Owner

@simon360 simon360 commented Dec 12, 2018 •
edited
Loading

  • Adds a .prettierrc file so that the default settings are applied
  • Extracts rehydrateChildren to a separate file to aid in later testing
  • Exports IOptions and IRehydrator for use in other projects
  • Adds unit tests for rehydrator.ts

Closes #15
Closes #32
Relates to #16

To do:

  • cover the case where a rehydrated element has been removed before a render could happen (line 46)
  • organize tests more effectively with describe()

@simon360 simon360 self-assigned this Dec 12, 2018
@simon360 simon360 changed the title Add unit tests for rehydrator.ts WIP: Add unit tests for rehydrator.ts Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@simon360 simon360

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@simon360