chore(fe): switch banners for mobile mainpage #3340
Conversation
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 81.3%, saving 49.7 KB.
|
|
❗ Syncing Preview App Failed Application: |
|
지금 ArgoCD Sync가 안될건데 이미지 Pull 제한 걸려서 그렇습니다. |
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 5.8%, saving 161 B.
1 image did not require optimisation. |
|
❗ Syncing Preview App Failed Application: |
|
|
Clover229
left a comment
Clover229
left a comment
There was a problem hiding this comment.
description에 전과 후 배너 사진을 넣으면 좋을 것 같습니다!
| <Link href={`/notice/${contestNoticeId}`} className="block w-full"> | ||
| <div className="relative h-[132px] w-full overflow-hidden"> | ||
| <Image | ||
| src={'/banners/mobile_mainpage_middle_banner.png'} |
There was a problem hiding this comment.
배너 사진이 너무 깨집니다! svg로 저장해주세요~
There was a problem hiding this comment.
28줄 font semibold 만 남겨주세요
| sub: "Practice real problems, compete with peers.\nGrow your skills on SKKU's coding platform.", | ||
| subMobile: 'Compete. Grow. SKKU Coding', | ||
| img: '/banners/main_banner.png', | ||
| imgMobile: '/banners/mobile_main_banner.png', |
| </p> | ||
| </div> | ||
| {/* Mobile View (render all slides and control visibility by facade) */} | ||
| <div className="mt-[10px] px-[20px] lg:hidden"> |
There was a problem hiding this comment.
새로운 모바일 사진이 lg크기에 어울리지 않는것 같아서, 자연스러운 반응형을 위해서 lg 대신 md로 통일하는 것이 어떨까요? 해당 캐러샐 페이지와 middlecontestBanner 모두요
| </div> | ||
| <div className="flex h-[30px] items-center justify-center gap-[6px]"> | ||
|
|
||
| <div className="mt-4 flex h-[30px] items-center justify-center gap-[6px]"> |
There was a problem hiding this comment.
점 세 개 없애주세요! 배너가 한 개라 무의미합니다.
Description
Additional context
closes TAS-2364
Before submitting the PR, please make sure you do the following
fixes #123).