feat: Centralize and expose a registerTypeAdapters method on GsonFactory #1510
+21
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralize and expose a
registerTypeAdapters
method onGsonFactory
Typically on larger projects,
gson
needs to be configured with many other adapters and configurations. The way theGsonFactory
class onslack-api-client
currently expose a finalized, pre-builtgson
instances makes it less reusable for users, who would have to copy the adapter registration configuration one-by-one if they already have agson
of their own.In fact, even within
GsonFactory
, the code is already repeated thrice, which can lead to desynchronization issues - which, in fact, did happen, as the last version had two repeated registrations (MessageChangedEvent.PreviousMessage
andLogsResponse.DetailsChangedValue
) and two missing registrations (FunctionExecutedEvent.InputValue
,Attachment.VideoHtml
), clearly a copy-paste mistake (unless this was intentional, but the reason would most certainly elude me).This unifies all instances to use the same shared method, and expose it so users can create their own instances as well.
Category (place an
x
in each of the[ ]
)Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.