feat: support snapshot releases in release process #1514
Conversation
WilliamBergamin
added
enhancement
| dir=`dirname $0`/.. | ||
| release_version=`sed -n 's/<version>\([^\$]\..*\)<\/version>$/\1/p' < ${dir}/pom.xml` | ||
| dir=$(dirname "$0")/.. | ||
| release_version=$(sed -n 's/^[[:space:]]*<version>\([^\$]\..*\)<\/version>[[:space:]]*$/\1/p' < "${dir}"/pom.xml) |
There was a problem hiding this comment.
IIUC, the update to this command* removes spaces that were being added to the release_version variable?
Based on local testing I got
% release_version=`sed -n 's/<version>\([^\$]\..*\)<\/version>$/\1/p' < pom.xml`
% echo $release_version
1.45.5-SNAPSHOT
# vs.
% release_version=$(sed -n 's/^[[:space:]]*<version>\([^\$]\..*\)<\/version>[[:space:]]*$/\1/p' < pom.xml)
% echo $release_version
1.45.5-SNAPSHOT
There was a problem hiding this comment.
Yes exactly 🚀
(From the test failure on the bolt project) Do we need to update the version of this dependency? Actually, I thought the Maven repository didn't let you delete older versions. Not sure if the existence of this page means it should still be available |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1514 +/- ##
============================================
+ Coverage 73.02% 73.06% +0.04%
- Complexity 4381 4382 +1
============================================
Files 475 475
Lines 14222 14222
Branches 1447 1447
============================================
+ Hits 10385 10391 +6
+ Misses 2980 2973 -7
- Partials 857 858 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
These changes update the release process to support snapshot releases. It documents how to release a snapshot release and updates the release script to be less error prone.
Category
Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.