fix: uniform client features enablement #1587
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
antfu
reviewed
May 12, 2024
| const DrawingControls = shallowRef<any>() | ||
| if (drawingEnabled) | ||
| import('../internals/DrawingControls.vue').then(v => DrawingControls.value = v.default) | ||
|
|
||
| const WebCamera = shallowRef<any>() | ||
| const RecordingDialog = shallowRef<any>() | ||
| if (__SLIDEV_FEATURE_RECORD__) { | ||
| if (features.record) { |
There was a problem hiding this comment.
The reason we use the flag and static replacement is for tree-shaking. When the feature is disabled, the corresponding module should not be shipped to user's client bundle at all because Rollup will remove if (false) {}
Is the new approach still behaviours like that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uniforms the feature enablement, and fixes that disabled features were displayed on the context menu