-
Notifications
You must be signed in to change notification settings - Fork 498
wire SkipValidation further into SCEP provisioner #1991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
thanks for the review, I have made the requested changes. |
@mishaslavin one minor linting issue found |
5d49710
to
e2f8f88
Compare
Hey @mishaslavin, had forgotten about this one, but noticed you closed the PR. Was that intentional? Afaik we would still merge it; just needed the CI to go green. |
Sorry, was unintentional to close it. I will resubmit a fresh copy from an actual branch, i did not realize this was a PR from my fork's master. |
Great! Just @ me, and I'll see it 🙂 |
Thanks! for posterity, #2305 |
Name of feature:
pass SkipValidation further into the SCEP provisioner
Pain or issue this feature alleviates:
When writing custom integrations, some of the validations don't apply, which unintentionally prevents the provisioner from starting up.
Why is this important to the project (if not answered above):
Is there documentation on how to use this feature? If so, where?
No additional docs
In what environments or workflows is this feature supported?
Primarily for custom integrations which create their own provisioner/authority objects
In what environments or workflows is this feature explicitly NOT supported (if any)?
Supporting links/other PRs/issues:
💔Thank you!