Skip to content

Conversation

mishaslavin
Copy link

Name of feature:

pass SkipValidation further into the SCEP provisioner

Pain or issue this feature alleviates:

When writing custom integrations, some of the validations don't apply, which unintentionally prevents the provisioner from starting up.

Why is this important to the project (if not answered above):

Is there documentation on how to use this feature? If so, where?

No additional docs

In what environments or workflows is this feature supported?

Primarily for custom integrations which create their own provisioner/authority objects

In what environments or workflows is this feature explicitly NOT supported (if any)?

Supporting links/other PRs/issues:

💔Thank you!

@CLAassistant
Copy link

CLAassistant commented Sep 10, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Sep 10, 2024
@mishaslavin
Copy link
Author

thanks for the review, I have made the requested changes.

@hslatman hslatman added this to the v0.27.5 milestone Sep 24, 2024
@hslatman hslatman self-assigned this Sep 24, 2024
@hslatman
Copy link
Member

@mishaslavin one minor linting issue found

@hslatman hslatman modified the milestones: v0.27.5, v0.27.6 Oct 22, 2024
@hslatman hslatman modified the milestones: v0.28.0, v0.28.1 Oct 30, 2024
@hslatman hslatman modified the milestones: v0.28.1, v0.28.2 Nov 21, 2024
@hslatman hslatman modified the milestones: v0.28.2, v0.28.3 Feb 20, 2025
@hslatman hslatman modified the milestones: v0.28.3, v0.28.4 Mar 18, 2025
@mishaslavin mishaslavin force-pushed the master branch 3 times, most recently from 5d49710 to e2f8f88 Compare June 11, 2025 17:50
@mishaslavin mishaslavin deleted the branch smallstep:master June 11, 2025 21:29
@mishaslavin mishaslavin deleted the master branch June 11, 2025 21:29
@hslatman
Copy link
Member

Hey @mishaslavin, had forgotten about this one, but noticed you closed the PR. Was that intentional? Afaik we would still merge it; just needed the CI to go green.

@mishaslavin
Copy link
Author

Hey @mishaslavin, had forgotten about this one, but noticed you closed the PR. Was that intentional? Afaik we would still merge it; just needed the CI to go green.

Sorry, was unintentional to close it. I will resubmit a fresh copy from an actual branch, i did not realize this was a PR from my fork's master.

@hslatman
Copy link
Member

Sorry, was unintentional to close it. I will resubmit a fresh copy from an actual branch, i did not realize this was a PR from my fork's master.

Great! Just @ me, and I'll see it 🙂

@mishaslavin
Copy link
Author

Thanks! for posterity, #2305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants