Skip to content

Conversation

wangerekaharun
Copy link
Member

@wangerekaharun wangerekaharun commented Sep 30, 2025

User description

Story: https://app.shortcut.com/smileid/story/xxx

Summary

A few sentences/bullet points about the changes

Known Issues

Any shortcomings in your work. This may include corner cases not correctly handled or issues related
to but not within the scope of your PR. Design compromises should be discussed here if they were not
already discussed above.

Test Instructions

Concise test instructions on how to verify that your feature works as intended. This should include
changes to the development environment (if applicable) and all commands needed to run your work.

Screenshot

If applicable (e.g. UI changes), add screenshots to help explain your work.


PR Type

Enhancement


Description

  • Removed selfie quality model checks from EnhancedSmartSelfie capture flow

  • Eliminated TensorFlow Lite dependencies and ML model binding configuration

  • Cleaned up SelfieQualityModel references from biometric and document verification screens

  • Removed quality threshold validation and model inference logic from selfie capture


File Walkthrough

Relevant files
Dependencies
1 files
lib.gradle.kts
Removed ML model binding and TensorFlow Lite dependencies
+0/-5     
Enhancement
5 files
SmileIDExtV2.kt
Removed SelfieQualityModel initialization from SmartSelfie enrollment
and authentication
+0/-9     
OrchestratedBiometricKYCScreen.kt
Removed SelfieQualityModel parameter from biometric KYC selfie capture
+0/-6     
OrchestratedDocumentVerificationScreen.kt
Removed SelfieQualityModel parameter from document verification selfie
capture
+0/-6     
SelfieCaptureScreenEnhanced.kt
Removed SelfieQualityModel parameter from enhanced selfie capture
screen
+0/-3     
SmartSelfieEnhancedViewModel.kt
Removed quality model inference logic and PoorImageQuality hint
handling
+0/-54   
Documentation
1 files
CHANGELOG.md
Added changelog entry for selfie quality checks removal   
+7/-0     
Miscellaneous
1 files
.gitkeep
Removed ML directory placeholder file                                       
+0/-1     
Additional files
1 files
selfie_quality_model.tflite [link]   


Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @prfectionist
    Copy link
    Contributor

    prfectionist bot commented Sep 30, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Unused Variable

    The selfieQualityHistory mutable list is still being declared and initialized but is no longer being used after removing the quality model logic. This should be removed to clean up the code.

    private val selfieQualityHistory = mutableListOf<Float>()
    Incomplete Removal

    The constant FACE_QUALITY_THRESHOLD was removed, but the comment referencing image quality model inference logic at line 385 area may need review to ensure all related documentation and logic has been properly cleaned up.

    if (shouldUseActiveLiveness) {
        _uiState.update {
            it.copy(selfieState = SelfieState.Analyzing(activeLiveness.selfieHint))
        }

    …cedViewModel.kt
    
    Co-authored-by: prfectionist[bot] <187910262+prfectionist[bot]@users.noreply.github.com>
    @wangerekaharun wangerekaharun changed the title Feat: Remove Selfie Quality Checks on EnhancedSmartSelfie Feat: Remove Selfie Quality Model on EnhancedSmartSelfie Sep 30, 2025
    jumaallan
    jumaallan previously approved these changes Sep 30, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants