-
Notifications
You must be signed in to change notification settings - Fork 7
Feat: Remove Selfie Quality Model on EnhancedSmartSelfie #767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…t verification screens
… and document verification screens
… and document verification screens
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
lib/src/main/java/com/smileidentity/viewmodel/SmartSelfieEnhancedViewModel.kt
Outdated
Show resolved
Hide resolved
lib/src/main/java/com/smileidentity/viewmodel/SmartSelfieEnhancedViewModel.kt
Show resolved
Hide resolved
…cedViewModel.kt Co-authored-by: prfectionist[bot] <187910262+prfectionist[bot]@users.noreply.github.com>
…m EnhancedSmartSelfie
…s' into feat/remove-selfie-quality-models
User description
Story: https://app.shortcut.com/smileid/story/xxx
Summary
A few sentences/bullet points about the changes
Known Issues
Any shortcomings in your work. This may include corner cases not correctly handled or issues related
to but not within the scope of your PR. Design compromises should be discussed here if they were not
already discussed above.
Test Instructions
Concise test instructions on how to verify that your feature works as intended. This should include
changes to the development environment (if applicable) and all commands needed to run your work.
Screenshot
If applicable (e.g. UI changes), add screenshots to help explain your work.
PR Type
Enhancement
Description
Removed selfie quality model checks from EnhancedSmartSelfie capture flow
Eliminated TensorFlow Lite dependencies and ML model binding configuration
Cleaned up
SelfieQualityModel
references from biometric and document verification screensRemoved quality threshold validation and model inference logic from selfie capture
File Walkthrough
1 files
Removed ML model binding and TensorFlow Lite dependencies
5 files
Removed SelfieQualityModel initialization from SmartSelfie enrollment
and authentication
Removed SelfieQualityModel parameter from biometric KYC selfie capture
Removed SelfieQualityModel parameter from document verification selfie
capture
Removed SelfieQualityModel parameter from enhanced selfie capture
screen
Removed quality model inference logic and PoorImageQuality hint
handling
1 files
Added changelog entry for selfie quality checks removal
1 files
Removed ML directory placeholder file
1 files