Skip to content

Address high cpu usage with AWSCRTHTTPClient #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 21, 2025
Merged

Address high cpu usage with AWSCRTHTTPClient #573

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9abf092
initial high cpu fix changes
jonathan343 Oct 14, 2025
8098c6a
fix type checks and remove outdated tests
jonathan343 Oct 14, 2025
1d4d782
update pyright version
jonathan343 Oct 16, 2025
b68df1b
Add tests
jonathan343 Oct 16, 2025
96f7dae
change crt_http_base back to crt_http
jonathan343 Oct 16, 2025
02e3e20
Add changelog and use default buffer size
jonathan343 Oct 17, 2025
7411240
Use 8KB buffer default size and make it configurable
jonathan343 Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/smithy-http/.changes/next-release/smithy-http-breaking-20251017150112.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "breaking",
"description": "Update `AWSCRTHTTPClient` to integrate with the new AWS CRT async interfaces. ([#573](https://github.com/smithy-lang/smithy-python/pull/573))"
}
2 changes: 1 addition & 1 deletion packages/smithy-http/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ dependencies = [

[project.optional-dependencies]
awscrt = [
"awscrt>=0.23.10",
"awscrt~=0.28.2",
Copy link
Contributor Author

@jonathan343 jonathan343 Oct 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Setting awscrt v0.28.2 is necessary since we need the change added in awslabs/aws-crt-python#688. Also, this was previously unbounded which has been fine for now, but constraining it to ~=0.28.2 is much safer for customers

]
aiohttp = [
"aiohttp>=3.11.12, <4.0",
Expand Down
Loading
Loading