Make slack work as discord #1067
Conversation
northdpole
force-pushed
the
make-slack-work-as-discord
branch
from
54bb09e to
136580f
Compare
northdpole
force-pushed
the
make-slack-work-as-discord
branch
from
136580f to
11331c6
Compare
| SlackChannelID string | ||
| SlackDebug bool | ||
|
|
||
| BaseClient *http.Client |
There was a problem hiding this comment.
since we are using this http client over here, we should use a round tripper to test that the request is formed as expected and we can handle the response and the various errors generated by the slack API
There was a problem hiding this comment.
but, that's why we use the library, are we testing that the library performs as expected?
| RunName string | ||
| } | ||
|
|
||
| func (r slackReporter) getThreadHeading(numFindings int) (string, error) { |
There was a problem hiding this comment.
since we have the ThreadData struct why not have a String method on it that invokes the template and passes itself to it? also, do we need a whole separate file embedded into the code for a one liner? we could have it as a string in this file
There was a problem hiding this comment.
I prefer templates if i'm super honest, it is super straightforward to write and see what's going on when you have Markdown in a file instead of some arbitrary string in the code. Personal preference ofc
|
The link to the issues should be updated to point to the new issue URL. It should also display the URL correctly in Slack: |
northdpole
force-pushed
the
make-slack-work-as-discord
branch
2 times, most recently
from
2d3ce50 to
5deb93f
Compare
…lates exactly like the Discord component would. -- Dependencies
northdpole
force-pushed
the
make-slack-work-as-discord
branch
from
5deb93f to
da99246
Compare
Make slack create a thread per scan and messages on the thread for every finding found