NO-SNOW fix tiny typo in DataTypes.md #1153
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
sfc-gh-dszmolka
requested review from
sfc-gh-pbulawa,
sfc-gh-knozderko and
sfc-gh-mhofman
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1153 +/- ##
==========================================
- Coverage 87.64% 87.58% -0.06%
==========================================
Files 133 133
Lines 12818 12818
Branches 1320 1320
==========================================
- Hits 11234 11227 -7
- Misses 1260 1265 +5
- Partials 324 326 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
doc/DataTypes.md
Outdated
| | `bool` | `BOOLEAN` | | ||
| | `byte` | `BINARY` | | ||
| | `datetime` | `DATE` | | ||
| | .NET Framework Data Type | Data Type in Snowflake | |
There was a problem hiding this comment.
maybe just .NET Data type
There was a problem hiding this comment.
ok, modified
sfc-gh-pbulawa
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code isn't changed, this is a documentation update.
This is a very small negligible issue which was accidentally discovered on one of the Support weekly calls, but since it was discovered, why not fix it.