Skip to content

SNOW-2148519: Fix arrow result format for multistatements #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jul 25, 2025

Conversation

sfc-gh-ext-simba-lf
Copy link
Collaborator

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf commented Jun 10, 2025

Description

Fix arrow result format for multistatements

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

Copy link

codecov bot commented Jun 10, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.93%. Comparing base (cac281d) to head (afe7eb0).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
Snowflake.Data/Core/ArrowResultSet.cs 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1190      +/-   ##
==========================================
+ Coverage   87.88%   87.93%   +0.04%     
==========================================
  Files         171      171              
  Lines       14410    14410              
  Branches     1465     1465              
==========================================
+ Hits        12664    12671       +7     
+ Misses       1374     1369       -5     
+ Partials      372      370       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf changed the title NO-SNOW: Use JSON for multistatement tests SNOW-2148519: Fix arrow result format for multistatements Jun 12, 2025
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf marked this pull request as ready for review June 30, 2025 17:21
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf requested a review from a team as a code owner June 30, 2025 17:21
@sfc-gh-dstempniak
Copy link
Collaborator

@sfc-gh-ext-simba-lf Tests fail on AWS and GCP, PTAL

@sfc-gh-ext-simba-lf
Copy link
Collaborator Author

@sfc-gh-ext-simba-lf Tests fail on AWS and GCP, PTAL

@sfc-gh-dstempniak Is it possible that arrow support for multi-statement queries are not enabled on those github test accounts?

I've tried on our Simba accounts for AWS and GCP and the result format was arrow

@sfc-gh-ext-simba-lf
Copy link
Collaborator Author

@sfc-gh-ext-simba-lf Tests fail on AWS and GCP, PTAL

The tests are now passing with the latest update from master

@sfc-gh-pcyrek sfc-gh-pcyrek changed the base branch from master to adjust_authentication_tests_error_message July 23, 2025 16:18
@sfc-gh-pcyrek sfc-gh-pcyrek changed the base branch from adjust_authentication_tests_error_message to master July 23, 2025 16:18
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf merged commit 01ffc5a into master Jul 25, 2025
63 of 66 checks passed
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf deleted the NO-SNOW-Fix-Multistatement-Tests branch July 25, 2025 05:43
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants