Skip to content

Conversation

sfc-gh-dszmolka
Copy link
Contributor

@sfc-gh-dszmolka sfc-gh-dszmolka commented Jul 16, 2025

Description

This came out of #1194 where it was an unnecessarily long struggle to setup MFA token caching, mostly due to how it is entirely undocumented.

This PR aims to change that.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-dszmolka sfc-gh-dszmolka requested a review from a team as a code owner July 16, 2025 12:56
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.91%. Comparing base (3a56390) to head (e8679a8).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1201      +/-   ##
==========================================
+ Coverage   87.90%   87.91%   +0.01%     
==========================================
  Files         171      171              
  Lines       14410    14410              
  Branches     1465     1465              
==========================================
+ Hits        12667    12669       +2     
+ Misses       1372     1371       -1     
+ Partials      371      370       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-dszmolka sfc-gh-dszmolka changed the title SNOW-2169830 document MFA token caching, and add the relevant param to session properties SNOW-2169830 document MFA token caching Jul 17, 2025
@sfc-gh-dszmolka sfc-gh-dszmolka requested a review from a team July 17, 2025 17:32
@sfc-gh-dszmolka sfc-gh-dszmolka enabled auto-merge (squash) July 17, 2025 17:32
Copy link
Collaborator

@sfc-gh-pbulawa sfc-gh-pbulawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Client credentials flow does not have the caching.

Co-authored-by: Piotr Bulawa <piotr.bulawa@snowflake.com>
@sfc-gh-dszmolka sfc-gh-dszmolka requested review from sfc-gh-pbulawa and a team July 23, 2025 07:10
Copy link
Collaborator

@sfc-gh-pbulawa sfc-gh-pbulawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-dszmolka sfc-gh-dszmolka enabled auto-merge (squash) July 23, 2025 07:57
@sfc-gh-dszmolka
Copy link
Contributor Author

Jenkins required build failing due to reason unrelated to this doc-only change. @sfc-gh-knozderko or @sfc-gh-pbulawa do you think this PR could be force-merged?

@sfc-gh-pbulawa
Copy link
Collaborator

Jenkins required build failing due to reason unrelated to this doc-only change. @sfc-gh-knozderko or @sfc-gh-pbulawa do you think this PR could be force-merged?

Seems fine with me. @sfc-gh-knozderko WDYT?

@sfc-gh-dszmolka sfc-gh-dszmolka merged commit cac281d into master Jul 24, 2025
64 of 65 checks passed
@sfc-gh-dszmolka sfc-gh-dszmolka deleted the SNOW-2169830-mfa-token-caching-docs-and-sessionproperty branch July 24, 2025 13:56
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants