-
Notifications
You must be signed in to change notification settings - Fork 150
SNOW-2169830 document MFA token caching #1201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-2169830 document MFA token caching #1201
Conversation
…o session properties
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #1201 +/- ##
==========================================
+ Coverage 87.90% 87.91% +0.01%
==========================================
Files 171 171
Lines 14410 14410
Branches 1465 1465
==========================================
+ Hits 12667 12669 +2
+ Misses 1372 1371 -1
+ Partials 371 370 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Client credentials flow does not have the caching.
Co-authored-by: Piotr Bulawa <piotr.bulawa@snowflake.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jenkins required build failing due to reason unrelated to this doc-only change. @sfc-gh-knozderko or @sfc-gh-pbulawa do you think this PR could be force-merged? |
Seems fine with me. @sfc-gh-knozderko WDYT? |
Description
This came out of #1194 where it was an unnecessarily long struggle to setup MFA token caching, mostly due to how it is entirely undocumented.
This PR aims to change that.
Checklist
dotnet test
)