Skip to content

fix(iOS): add a check that the href attribute exists in link params #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IvanIhnatsiuk wants to merge 4 commits into from
Closed

fix(iOS): add a check that the href attribute exists in link params #223

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
97c327b
fix: add a check that the href attribute exists in link params
IvanIhnatsiuk Nov 3, 2025
91aada4
fix: always add stylePair
IvanIhnatsiuk Nov 7, 2025
1190284
fix: spacing
IvanIhnatsiuk Nov 14, 2025
82535af
Merge branch 'main' into fix/iOS-crash-caused-by-missing-href-attribute
IvanIhnatsiuk Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ios/inputParser/InputParser.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,10 +597,13 @@ - (NSArray *)getTextAndStylesFromHtml:(NSString *)fixedHtml {
} else if([tagName isEqualToString:@"code"]) {
[styleArr addObject:@([InlineCodeStyle getStyleType])];
} else if([tagName isEqualToString:@"a"]) {
[styleArr addObject:@([LinkStyle getStyleType])];
// cut only the url from the href="..." string
NSString *url = [params substringWithRange:NSMakeRange(6, params.length - 7)];
stylePair.styleValue = url;
[styleArr addObject:@([LinkStyle getStyleType])];
NSRange hrefRange = [params rangeOfString:@"href="];
stylePair.styleValue = @"";
if(hrefRange.location != NSNotFound) {
NSString *url = [params substringWithRange:NSMakeRange(6, params.length - 7)];
stylePair.styleValue = url;
}
} else if([tagName isEqualToString:@"mention"]) {
[styleArr addObject:@([MentionStyle getStyleType])];
// extract html expression into dict using some regex
Expand Down