-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Simplify VirtualDetector/InterceptingGestureDetector and reduce the number of renders
#3813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
j-piasecki
wants to merge
11
commits into
next
Choose a base branch
from
@jpiasecki/optimize-virtual-detector
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+139
−132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
349e799 to
297e0cd
Compare
797299c to
86423e1
Compare
297e0cd to
19ea1a9
Compare
j-piasecki
added a commit
that referenced
this pull request
Nov 13, 2025
…#3814) ## Description Adds an early return inside `removeContextMenuListeners` so that it doesn't throw when `detach` and `dropHandler` are called consecutively. This is possible in v3 api, where the gesture lifecycle isn't tied to the detector component. ## Test plan Found when working on #3813, not sure how to reproduce it outside of it, but to reproduce it there use this: ``` import * as React from 'react'; import { Button, StyleSheet, Text, View } from 'react-native'; import { GestureDetector, InterceptingGestureDetector, useTap, } from 'react-native-gesture-handler'; export const COLORS = { NAVY: '#001A72', KINDA_RED: '#FFB2AD', YELLOW: '#FFF096', KINDA_GREEN: '#C4E7DB', KINDA_BLUE: '#A0D5EF', }; function TextWithTap() { const tap = useTap({ onStart: () => { 'worklet'; console.log('Tapped on text in its own component!'); }, }); return ( <GestureDetector gesture={tap}> <Text style={{ fontSize: 24, color: COLORS.KINDA_GREEN }}> This text is rendered in a separate component. </Text> </GestureDetector> ); } function NativeDetectorExample() { const [entireVisible, setEntireVisible] = React.useState(true); const [firstVisible, setFirstVisible] = React.useState(true); const [secondVisible, setSecondVisible] = React.useState(true); const [thirdVisible, setThirdVisible] = React.useState(true); const [secondKey, setSecondKey] = React.useState(0); const [firstHasCallback, setFirstHasCallback] = React.useState(true); const tapAll = useTap({ onStart: () => { 'worklet'; console.log('Tapped on text!'); }, }); const tapFirstPart = useTap({ onStart: firstHasCallback ? () => { 'worklet'; console.log('Tapped on first part!'); }: () => { 'worklet'; console.log('First part tapped, but no callback set.'); }, }); const tapSecondPart = useTap({ onStart: () => { 'worklet'; console.log('Tapped on second part!'); }, }); return ( <View style={styles.subcontainer}> <Button title={(firstVisible ? 'Hide' : 'Show') + ' entire text'} onPress={() => setEntireVisible(v => !v)} /> <Button title={(firstVisible ? 'Hide' : 'Show') + ' first part'} onPress={() => setFirstVisible(v => !v)} /> <Button title={(secondVisible ? 'Hide' : 'Show') + ' second part'} onPress={() => setSecondVisible(v => !v)} /> <Button title={(thirdVisible ? 'Hide' : 'Show') + ' third part'} onPress={() => setThirdVisible(v => !v)} /> <Button title="Re-mount second part" onPress={() => setSecondKey(k => k + 1)} /> <Button title={(firstHasCallback ? 'Disable' : 'Enable') + ' callback on first text'} onPress={() => setFirstHasCallback(v => !v)} /> {entireVisible && <InterceptingGestureDetector gesture={tapAll}> <Text style={{ fontSize: 18, textAlign: 'center' }}> Some text example running with RNGH {firstVisible && <GestureDetector gesture={tapFirstPart}> <Text style={{ fontSize: 24, color: COLORS.NAVY }}> {' '} try tapping on this part </Text> </GestureDetector>} {secondVisible && <GestureDetector gesture={tapSecondPart}> <Text key={secondKey} style={{ fontSize: 28, color: COLORS.KINDA_BLUE }}> {' '} or on this part </Text> </GestureDetector>} {thirdVisible && <> {' '} <TextWithTap /> </>} {' '} this part is not special :( </Text> </InterceptingGestureDetector>} </View> ); } export default function NativeTextExample() { return ( <View style={styles.container}> <NativeDetectorExample /> </View> ); } const styles = StyleSheet.create({ container: { flex: 1, }, subcontainer: { flex: 1, gap: 8, alignItems: 'center', justifyContent: 'center', }, header: { fontSize: 18, textAlign: 'center', paddingHorizontal: 24, }, }); ``` and press `Hide entire text`
m-bert
reviewed
Nov 13, 2025
...eact-native-gesture-handler/src/v3/detectors/VirtualDetector/InterceptingGestureDetector.tsx
Outdated
Show resolved
Hide resolved
m-bert
reviewed
Nov 14, 2025
Contributor
m-bert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I'll leave approval for @akwasniewski as he is the author of VirtualDetector 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The communication logic between
VirtualDetector/InterceptingGestureDetectorwas complex, since it was passing callbacks through ref and everything else through state via context.Since we're relying on Reanimated's
useEventanduseComposedEventHandler, we need to trigger a rerender anyway to update the handler. This means there's no point in trying to optimize passing callbacks via refs, as we need to end with a render, and synchronizing renders and state updates requires additional logic.This PR simplifies the communication layer to pass everything through the state, which should greatly simplify logic.
It also:
shouldUseReanimated,dispatchesAnimatedEventsflags - now it checks every virtual gesture, where previously the last registered one was the deciding factorVirtualDetectorso that children changes can be detected - this should be changed to use MutationObserver once it's rolled out in RNInterceptingGestureDetectorTest plan
Tested on the following snippet: