Memoize cloned configs in gesture hooks #3816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-bert
reviewed
Nov 13, 2025
Contributor
m-bert
left a comment
m-bert
left a comment
There was a problem hiding this comment.
(...)(will require other PRs to be merged first).
Could you add those PRs to the description (if they're already submitted)?
packages/react-native-gesture-handler/src/v3/hooks/gestures/fling/useFling.ts
Show resolved
Hide resolved
packages/react-native-gesture-handler/src/v3/hooks/gestures/pinch/usePinch.ts
Show resolved
Hide resolved
packages/react-native-gesture-handler/src/v3/hooks/gestures/rotation/useRotation.ts
Show resolved
Hide resolved
m-bert
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently config is cloned and modified on every render in gesture hooks. This PR changes that, so that it's memoized assuming the input is also stable.
Test plan
Verify that if the input config is memoized, the returned gesture reference is stable as long as the config doesn't change (will require other PRs to be merged first).