-
-
Notifications
You must be signed in to change notification settings - Fork 600
feat: Add ContentScrollViewDetector component #3463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kmichalikk
wants to merge
10
commits into
main
Choose a base branch
from
@kmichalikk/scroll-view-hosting-component
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+266
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3fd2e1a to
374b9ab
Compare
t0maboro
reviewed
Dec 9, 2025
t0maboro
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: ScrollView
Issue related to integration between library and ScrollView component
Type: Feature
Issue or PR with feature request or implementation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
ContentScrollViewDetectornative component. This component allows us to locate and interface with content ScrollView.The component holds an instance to the ScrollView and registers it for the closest view that implements ContentScrollViewConsumer. It is also responsible for unregistering the view when the ScrollView is destroyed.
We do not support the case when
ContentScrollViewDetectordoes not wrap any ScrollView or the ScrollView is detached after some time. In the second case, the application will likely crash. Similarly, we do not support nestedContentScrollViewDetectors.Changes
Added
ContentScrollViewDetectorcomponent. AddedContentScrollViewConsumerprotocol that theDetectorlooks for.Test code and steps to reproduce
Wrap a ScrollView with
<ContentScrollViewDetector>. Add the following toRNSScreenand/orRNSBottomTabsScreenComponentView:along with conformance declaration in the header. Observe the logs.