Add comments from Jon #28

joncinque · 2025-02-26T15:05:52Z

Problem

P-token is getting ready to be used everywhere, but it hasn't been reviewed!

Summary of changes

Nothing show-stopping, mostly nits and cleanup ideas. Great work! I also used some local crates so I could do some testing, so feel free to ignore all of that

#### Problem P-token is getting ready to be used everywhere, but it hasn't been reviewed! #### Summary of changes Nothing show-stopping, mostly nits and cleanup ideas. Great work!

interface/src/state/account.rs

interface/src/state/mint.rs

interface/src/state/mod.rs

p-token/src/processor/close_account.rs

p-token/src/processor/initialize_account2.rs

p-token/src/processor/initialize_account3.rs

p-token/src/processor/initialize_mint.rs

p-token/src/processor/mod.rs

p-token/src/processor/shared/initialize_multisig.rs

p-token/src/processor/shared/transfer.rs

p-token/src/processor/set_authority.rs

febo · 2025-03-05T12:57:57Z

p-token/src/processor/shared/burn.rs

        source_account.set_amount(updated_source_amount);

+        // JC nit: I think we could safely unwrap this, but I'm not sure if
+        // we get any real performance benefits


In that case, we could remove the checked math, right?

febo · 2025-03-05T13:37:37Z

p-token/src/processor/shared/initialize_account.rs

+        // JC nit: up to you, but since you've already checked that
+        // `lamports() < minimum_balance` earlier, you don't actually need
+        // checked math. If it shaves CUs, go for it! But definitely add a
+        // comment explaining why


Good point! Also we don't need to do the borrow_lamports_unchecked, since we are not updating its value.

// `new_account_info` lamports are already checked to be greater than or equal // to the minimum balance. account.set_amount(new_account_info.lamports() - minimum_balance);

Cargo.toml

Add comments from Jon

09c4ad4

#### Problem P-token is getting ready to be used everywhere, but it hasn't been reviewed! #### Summary of changes Nothing show-stopping, mostly nits and cleanup ideas. Great work!

joncinque requested a review from febo February 26, 2025 15:05