-
Notifications
You must be signed in to change notification settings - Fork 8
fix: PostRepository & CommentRepository의 일부 메서드의 정렬 순서 오류 해결 #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Hexeong
merged 21 commits into
solid-connection:develop
from
Hexeong:fix/521-community-query-order
Oct 2, 2025
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
0633ef1
fix: 보드와 카테고리에 따른 포스트 조회 메서드 정렬 문제 해결
Hexeong 89b0d95
test: 보드와 카테고리에 따른 포스트 조회 메서드 정렬 문제 해결 - 테스트 코드 수정
Hexeong 6e164c6
fix: 코멘트 트리 조회 메서드 정렬 문제 해결
Hexeong a61e8ae
test: 코멘트 트리 조회 메서드 정렬 문제 해결 - 테스트 코드 수정
Hexeong 8394ca0
style: PostRepository 메서드명 변경
Hexeong 7120341
chore: todo 메세지 제거
Hexeong c1344f6
chore: 디버그 코드 제거
Hexeong ec76fad
test: 내림차순 정렬 검증이 비결정적일 수 있는 문제 수정
Hexeong 563c71d
Revert "chore : debug code delete"
Hexeong 920002e
refactor: 테스트 코드가 프로덕션 코드에게 영향 미치지 않게 reflaction 방식으로 createdAt 설정 메서…
Hexeong d6ba7be
refactor: 테스트 코드가 프로덕션 코드에게 영향 미치지 않게 TestTimeHelper 코드를 적용한 방식으로 Fix…
Hexeong a607431
test: Comment 조회 메서드에 대한 순서 정렬 테스트 코드 추가
Hexeong f45446a
test: 게시판 조회 메서드에 대한 순서 정렬 테스트 코드 추가
Hexeong 6edde9b
test: 차단한 사용자 제외 댓글들 조회 메서드에 대한 순서 정렬 테스트 코드 추가
Hexeong 58b8bdf
fix: rebase로 인한 테스트 코드 오류 수정
Hexeong 244b292
test: import 구문 정리 & 디버깅 코드 제거
Hexeong 6b561f7
refactor: 중복 동작 로직 제거
Hexeong e193241
test: 중복 검증 로직 제거
Hexeong dbc7955
test: 컨벤션에 맞춘 와일드 카드 정리
Hexeong eb7c63c
test: 차단된 경우에서 순서 유지 검증하는 테스트 추가
Hexeong 774e3b2
chore: code reformatting 적용
Hexeong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
src/test/java/com/example/solidconnection/common/helper/TestTimeHelper.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package com.example.solidconnection.common.helper; | ||
|
|
||
| import com.example.solidconnection.common.BaseEntity; | ||
| import java.lang.reflect.Field; | ||
| import java.time.ZonedDateTime; | ||
| import java.time.temporal.ChronoUnit; | ||
|
|
||
| public class TestTimeHelper { | ||
|
|
||
| public static void setCreatedAt(BaseEntity entity, ZonedDateTime time) { | ||
| try { | ||
| Field field = BaseEntity.class.getDeclaredField("createdAt"); | ||
| field.setAccessible(true); | ||
| field.set(entity, time.truncatedTo(ChronoUnit.MICROS)); | ||
| } catch (Exception e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어라 이거도 레거시같은데
setParentCommentAndPostAndSiteUserId동작이setPostAndSiteUserId동작을 포함하네요 ... 여기 PR에 반영하는 게 나을까요 따로 PR 파는 게 나을까요 ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기서 같이 제거해도 될 거 같습니다!
7월에 반영된 거 같은데 놓쳤네요..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 반영하겠습니다!