-
Notifications
You must be signed in to change notification settings - Fork 8
refactor: CD 성능 개선 #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Hexeong
merged 16 commits into
solid-connection:develop
from
Hexeong:refactor/529-shortening-cd-time
Nov 15, 2025
Merged
refactor: CD 성능 개선 #552
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
98b7c03
fix: deprecated된 base image를 eclipse-temurin:17-jdk로 변경
Hexeong 83d611f
refactor: scp 파일 전송하는 방식에서 GHCR로 push/pull하도록 변경
Hexeong 216e83a
fix: GHCR image 제거시 Org의 GITHUB_TOKEN 사용하도록 변경
Hexeong 898d594
refactor : scp 파일 전송하는 방식에서 GHCR로 push/pull하도록 prod-cd.yml과 docker-co…
Hexeong a76e446
fix: prod 인스턴스 old image 이름 통일
Hexeong 59c0116
fix: prod-cd.yml StrictHostKeyChecking 옵션 문법 오류 수정
Hexeong c86901a
fix: prod-cd.yml StrictHostKeyChecking 옵션 문법 오류 수정
Hexeong 595c6aa
fix: dev-cd.yml Old images 정리 작업 중 이미지 이름 불일치 문제 해결
Hexeong 63a16fa
chore: 마지막 줄 개행 추가
Hexeong ab3054e
chore: 마지막 줄 개행 추가
Hexeong 01114c3
feat: stage 인스턴스에 대한 최신 이미지 5개 유지 기능 및 old 이미지 제거 기능 추가
Hexeong 229d9aa
chore: 중복된 환경변수 지정 제거
Hexeong 1b57e74
chore: 중복된 pem키 생성 로직 제거
Hexeong 0c431df
fix: 잘못된 pem키 이름 수정
Hexeong 7ae94b1
refactor: 원격 호스트에서 pull할 경우, 최소 권한으로 실행하도록 Github App으로 임시토큰 발급하도록 수정
Hexeong be3d47a
Merge remote-tracking branch 'origin/develop' into refactor/529-short…
Hexeong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github.repository_owner로 설정하면 레포 소유자 이름(e.g. whqtker)으로 고정되는 건가요 ? 만약 그렇다면,solid-connection과 같이 사용자에 종속되지 않는 이름으로 설정하는 게 좋을 거 같습니다 !There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Organization에 속한 레포의 워크플로우 실행의 경우
github.repository_owner은 Organization 이름인solid-connection이 됩니다! 때문에 사용자 이름으로 종속되지는 않아 해당 문제는 없을 것 같아요!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니다 ~!