feat: add popup actions builder #94
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @andrew-bekhiet-solid, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the LanguageToolMistakePopup by providing a flexible mechanism to extend its header with custom actions. This allows for greater customization and integration possibilities for the popup. Additionally, the file containing the popup logic has been formatted to adhere to standard Dart style guidelines.
Highlights
- New Feature: Popup Actions Builder: Introduced an actionsBuilder property to LanguageToolMistakePopup, allowing developers to add custom widgets to the popup's header, enhancing its extensibility.
- Code Formatting: Applied dart formatter to mistake_popup.dart, resulting in consistent naming conventions for local constants (e.g., _variableName to variableName) and general code style improvements.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a flexible actionsBuilder to the LanguageToolMistakePopup, allowing for custom actions to be added to the popup header. The implementation is clean and effectively utilizes modern Dart features. Additionally, the code in mistake_popup.dart has been formatted to better align with Dart styling conventions, which enhances readability and maintainability. The changes are well-executed, and I have one suggestion to further improve the code by removing a magic number.
style: move all constants to class static members
|
LGTM - could you please add CHANGELOG? We didn't release previous version yet so it still falls in 1.0.0. |
|
Closing in favor of #95 |
2 participants
Also runs dart formatter on
mistake_popup.dart