Skip to content

Conversation

milkyway-12
Copy link

@milkyway-12 milkyway-12 commented Sep 8, 2025

  • Added analyzer.plugins to test configuration example in README
  • Updated lib/analysis_options_test.yaml to include analyzer.plugins to get correct configuration file
  • Enabled cheching if file is test and getting correct directory
  • Replace run() with runRule() in all rule implementations

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @milkyway-12, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses issue #192 by ensuring that the analyzer.plugins configuration is correctly applied and documented for test environments. It updates both the example configuration in the README.md and the actual analysis_options_test.yaml file to properly enable custom linting plugins.

Highlights

  • Documentation Update: The README.md file has been updated to include the analyzer.plugins configuration in the example analysis_options.yaml for test setups, ensuring users correctly configure custom linting.
  • Test Configuration: The lib/analysis_options_test.yaml file now explicitly includes the analyzer.plugins section with custom_lint, which is necessary for the analysis server to correctly recognize and apply custom lint rules during testing.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the documentation and test configuration to ensure the custom_lint analyzer plugin is properly enabled. The change in README.md provides a clear setup example for users. The corresponding change in lib/analysis_options_test.yaml adds the same plugin configuration. While this appears redundant because the included analysis_options.yaml already contains this setting, it may be a necessary safeguard. I have added one suggestion to include a comment clarifying this redundancy to improve future maintainability.

Comment on lines +3 to +5
analyzer:
plugins:
- custom_lint

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This analyzer section appears to be redundant, as it is already defined in package:solid_lints/analysis_options.yaml, which is included in this file. The analyzer's configuration merging should handle this inheritance.

If this duplication is intentional—perhaps as a safeguard against issues with nested include directives in some tooling—it would be beneficial to add a comment explaining why it's necessary. This would improve maintainability by preventing future developers from removing it as dead code.

@milkyway-12
Copy link
Author

milkyway-12 commented Sep 11, 2025

Summary for changes, made in fork of custom_links.
https://www.notion.so/Summary-on-192-269344ce7b6280c0a3a5f52ef6ccbf0b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant