Skip to content

adds test cases for swapping objects/arrays on stores #2281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

adds test cases for swapping objects/arrays on stores #2281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions packages/solid/store/test/modifiers.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,32 @@ describe("setState with reconcile", () => {
setStore(reconcile({ value: { q: "aa" } }));
expect(store.value).toEqual({ q: "aa" });
});
test("reconciles an object with an array", () => {
const [store, setStore] = createStore<{ value: {} | [] }>({
value: { foo: "bar" }
});

const value = [0, 1, 2];
setStore("value", reconcile(value));

expect(Array.isArray(store.value)).toBe(true);
expect(store).toEqual({
value: [0, 1, 2]
});
});

test("reconciles an array with an object", () => {
const [store, setStore] = createStore<{ value: {} | [] }>({
value: [0, 1, 2]
});

const value = { foo: "bar" };
setStore("value", reconcile(value));
expect(Array.isArray(store.value)).toBe(false);
expect(store).toEqual({
value: { foo: "bar" }
});
});
});

describe("setState with produce", () => {
Expand Down
Loading