Skip to content
This repository was archived by the owner on Oct 3, 2021. It is now read-only.

create preprocessing_script.sh #1303

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

create preprocessing_script.sh #1303

wants to merge 12 commits into from

Conversation

goldmannc
Copy link

created a preprocessing script for the juliet test suite

@kfriedberger
some improvements for the script.
7459dc5 
- work without changing the directory, use directory names in commands.
- preprocessed files do no longer contain line numbers (parameter "-P").
- yml-files are properly formatted (the newline-formatted style might have been valid
yaml, but looked strangely intended).
- some cleanup.
@kfriedberger
formatting output to be more readable.
93d3ec5
MartinSpiessl
MartinSpiessl suggested changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@MartinSpiessl MartinSpiessl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks useful to me. No need to overcomplicate things.
I added some comments/suggestions for improvements.
I didn't run the script myself yet as @kfriedberger told me he will do that.
Maybe getting feedback from @Druidos might also be insightful, as he originally created the scripts that worked with these test cases.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@PhilippWendler PhilippWendler PhilippWendler left review comments

@kfriedberger kfriedberger kfriedberger left review comments

@MartinSpiessl MartinSpiessl MartinSpiessl requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@goldmannc @PhilippWendler @kfriedberger @MartinSpiessl