Skip to content

Conversation

@soulomoon
Copy link
Owner

No description provided.

gracefully exit the server
…111-hputbuf-resource-vanished-broken-pipe---test-option-j1-workaround
…ith a more flexible flaky-test-loop script, update test patterns handling, and improve logging and exit code interpretation.
The worker thread checks this flag before dequeuing each job; if set, it exits immediately,
ensuring that no new work is started after shutdown is requested.
This mechanism is necessary because some downstream code may swallow async exceptions,
making 'cancel' unreliable for stopping the thread in all cases.
If 'cancel' does interrupt the thread (e.g., while blocked in STM or in a cooperative job),
the thread exits immediately and never checks the TMVar; in such cases, the stop flag is redundant.
@soulomoon
Copy link
Owner Author

@copilot functions like copyTestDataFiles, run' ... in hls-refactor-plugin-tests are redudant. Consider migrating them to use runSessionWithTestConfig, since runSessionWithTestConfig already possible to copy test data with testDirLocation set to VirtualFileTree, take a look at mkVirtualFileTree. Also run', runWithExtraFiles in hls-refactor-plugin-tests we do not need withTempDir since runSessionWithTestConfig already can switch to a new tmp dir with mkVirtualFileTree. Also simplify related functions in hls-refactor-plugin-tests too

Copy link

Copilot AI commented Oct 31, 2025

@soulomoon I've opened a new pull request, #32, to work on those changes. Once the pull request is ready, I'll request review from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants