[bug] onboarding: fix infinite loop when using GCP IAP #381

drew-u410 · 2025-07-16T12:01:42Z

If GCP IAP Auth is used, you will enter an infinite loop when trying to auth due to updated onboarding flow.
This does not show the onboarding flow if these variables are set.

Repro:

Set the AUTH_EE_GCP_IAP_ENABLED and AUTH_EE_GCP_IAP_AUDIENCE and try to login.

Summary by CodeRabbit

Bug Fixes
- Resolved an issue causing an onboarding infinite loop when GCP IAP Authentication is enabled.
Documentation
- Updated the changelog with details about the onboarding loop fix under a new "Unreleased" section.

coderabbitai · 2025-07-16T12:02:21Z

Walkthrough

A new "Unreleased" section was added to the changelog to document a fix for an onboarding infinite loop when GCP IAP Authentication is enabled. The onboarding page display logic was updated to suppress onboarding if GCP IAP is enabled and configured, preventing the infinite loop scenario.

Changes

File(s)	Change Summary
CHANGELOG.md	Added "Unreleased" section noting fix for onboarding infinite loop with GCP IAP Authentication.
packages/web/src/app/[domain]/layout.tsx	Updated onboarding page logic to check GCP IAP enablement and configuration before showing page.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A loop once spun, onboarding anew,
But GCP IAP now sees us through.
With logic refined and conditions set,
The infinite spiral is no longer a threat.
Changelog updated, the fix is in view—
Hopping forward, as all good bunnies do! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 289c7fb and f0e6612.

📒 Files selected for processing (2)

CHANGELOG.md (1 hunks)
packages/web/src/app/[domain]/layout.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

CHANGELOG.md
packages/web/src/app/[domain]/layout.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: build

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

msukkari · 2025-07-16T18:45:36Z

Thanks for highlighting this @drew-u410!

I had added the following logic to the onboarding page to support the IAP bridge if the user isn't onboarded, but admittingly I didn't fully test this path:

sourcebot/packages/web/src/app/onboard/page.tsx

Line 81 in ee90edc

    
           if (ssoEntitlement && env.AUTH_EE_GCP_IAP_ENABLED && env.AUTH_EE_GCP_IAP_AUDIENCE) {

I'm trying to figure out the right approach here, because ideally we wouldn't have the onboarding flow be complete skipped when an IAP bridge is used.

Was your org not onboarded when you're hitting this infinite loop? Existing orgs should have had their isOnboarded flag be set to true

msukkari · 2025-07-16T18:47:50Z

If you could describe what the "infinite loop" while authing looked like it would help to figure out the underlying issue here

drew-u410 · 2025-07-16T18:48:37Z

Was your org not onboarded when you're hitting this infinite loop? Existing orgs should have had their isOnboarded flag be set to true

No idea, it just loops trying to load / auth.

Just configure with these two env vars and try to login (you can't).

I'm trying to figure out the right approach here, because ideally we wouldn't have the onboarding flow be complete skipped when an IAP bridge is used.

I think this is probably? okay. If you are setting these... you are probably way past onboarding.

msukkari · 2025-07-16T18:55:52Z

Sounds good, I will setup my GCP IAP environment and try to repro this as soon as I get the chance

msukkari · 2025-07-25T17:06:04Z

Going to merge this in for now so we don't block Ask Sourcebot release. Will revisit when I get the chance to find a longer term fix

[bug] onboarding: fix infinite loop when using GCP IAP

289c7fb

drew-u410 force-pushed the drew/onboarding_when_gcp_iap branch from 4cdea25 to 289c7fb Compare July 16, 2025 12:02

Merge branch 'main' into drew/onboarding_when_gcp_iap

f0e6612

msukkari approved these changes Jul 25, 2025

View reviewed changes

msukkari merged commit 4e34406 into sourcebot-dev:main Jul 25, 2025
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[bug] onboarding: fix infinite loop when using GCP IAP #381

[bug] onboarding: fix infinite loop when using GCP IAP #381

Uh oh!

drew-u410 commented Jul 16, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 16, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

msukkari commented Jul 16, 2025

Uh oh!

msukkari commented Jul 16, 2025

Uh oh!

drew-u410 commented Jul 16, 2025

Uh oh!

msukkari commented Jul 16, 2025

Uh oh!

msukkari commented Jul 25, 2025

Uh oh!

Uh oh!

Uh oh!

[bug] onboarding: fix infinite loop when using GCP IAP #381

[bug] onboarding: fix infinite loop when using GCP IAP #381

Uh oh!

Conversation

drew-u410 commented Jul 16, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

msukkari commented Jul 16, 2025

Uh oh!

msukkari commented Jul 16, 2025

Uh oh!

drew-u410 commented Jul 16, 2025

Uh oh!

msukkari commented Jul 16, 2025

Uh oh!

msukkari commented Jul 25, 2025

Uh oh!

Uh oh!

Uh oh!

drew-u410 commented Jul 16, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 16, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)